fixed due to comments

elastic · Apr 9, 2020 · ba19515 · ba19515
1 parent 3ca6b61
commit ba19515
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 5 deletions.
diff --git a/...ins/triggers_actions_ui/public/application/sections/action_connector_form/action_form.tsx b/...ins/triggers_actions_ui/public/application/sections/action_connector_form/action_form.tsx
@@ -141,12 +141,18 @@ export const ActionForm = ({
       });
     }
   }
+  const preconfiguredMessage = i18n.translate(
+    'xpack.triggersActionsUI.sections.alertForm.preconfiguredTitleMessage',
+    {
+      defaultMessage: '(pre-configured)',
+    }
+  );
   const getSelectedOptions = (actionItemId: string) => {
     const val = connectors.find(connector => connector.id === actionItemId);
     if (!val) {
       return [];
     }
-    const optionTitle = `${val.name}${val.isPreconfigured ? '(pre-configured)' : ''}`;
+    const optionTitle = `${val.name}${val.isPreconfigured ? preconfiguredMessage : ''}`;
     return [
       {
         label: optionTitle,
@@ -266,7 +272,7 @@ export const ActionForm = ({
                         id="xpack.triggersActionsUI.sections.alertForm.selectAlertActionTypeEditTitle"
                         values={{
                           actionConnectorName: `${actionConnector.name}${
-                            actionConnector.isPreconfigured ? '(pre-configured)' : ''
+                            actionConnector.isPreconfigured ? preconfiguredMessage : ''
                           }`,
                         }}
                       />

diff --git a/...s_ui/public/application/sections/action_connector_form/preconfigured_connector_flyout.tsx b/...s_ui/public/application/sections/action_connector_form/preconfigured_connector_flyout.tsx
@@ -44,7 +44,7 @@ export const PreconfiguredConnectorFlyout = ({
   const actionTypeModel = actionTypeRegistry.get(initialConnector.actionTypeId);
 
   return (
-    <EuiFlyout onClose={closeFlyout} aria-labelledby="flyoutActionAddTitle" size="m">
+    <EuiFlyout onClose={closeFlyout} aria-labelledby="flyoutPreconfiguredtActionTitle" size="m">
       <EuiFlyoutHeader hasBorder>
         <EuiFlexGroup gutterSize="s" alignItems="center">
           {actionTypeModel ? (
@@ -66,7 +66,7 @@ export const PreconfiguredConnectorFlyout = ({
                   tooltipContent={i18n.translate(
                     'xpack.triggersActionsUI.sections.preconfiguredConnectorForm.tooltipContent',
                     {
-                      defaultMessage: 'This connector is preconfigured and not allowed to edit',
+                      defaultMessage: 'This connector is preconfigured and cannot be edited',
                     }
                   )}
                 />

diff --git a/...ublic/application/sections/actions_connectors_list/components/actions_connectors_list.tsx b/...ublic/application/sections/actions_connectors_list/components/actions_connectors_list.tsx
@@ -219,7 +219,12 @@ export const ActionsConnectorsList: React.FunctionComponent = () => {
             <EuiFlexGroup justifyContent="flexEnd" alignItems="flexEnd">
               <EuiFlexItem grow={false}>
                 <EuiBetaBadge
-                  label="Pre-configured"
+                  label={i18n.translate(
+                    'xpack.triggersActionsUI.sections.alertForm.preconfiguredTitleMessage',
+                    {
+                      defaultMessage: 'Pre-configured',
+                    }
+                  )}
                   tooltipContent="This connector is not allowed to delete."
                 />
               </EuiFlexItem>