Skip to content

Commit

Permalink
Revert lazy conversion to stop creating separate chunk
Browse files Browse the repository at this point in the history
  • Loading branch information
kpollich committed Dec 6, 2023
1 parent 6bb7594 commit bd9979e
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -701,7 +701,3 @@ export const EditOutputFlyout: React.FunctionComponent<EditOutputFlyoutProps> =
</EuiFlyout>
);
};

// default export to support React.lazy
// eslint-disable-next-line import/no-default-export
export default EditOutputFlyout;
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
* 2.0.
*/

import React, { Suspense, useCallback } from 'react';
import { EuiLoadingSpinner, EuiPortal } from '@elastic/eui';
import React, { useCallback } from 'react';
import { EuiPortal } from '@elastic/eui';
import { useHistory, Redirect } from 'react-router-dom';
import { Routes, Route } from '@kbn/shared-ux-router';

Expand All @@ -31,8 +31,7 @@ import { useDeleteOutput, useDeleteFleetServerHost, useDeleteProxy } from './hoo
import { EditDownloadSourceFlyout } from './components/download_source_flyout';
import { useDeleteDownloadSource } from './components/download_source_flyout/use_delete_download_source';
import { FleetProxyFlyout } from './components/edit_fleet_proxy_flyout';

const EditOutputFlyout = React.lazy(() => import('./components/edit_output_flyout'));
import { EditOutputFlyout } from './components/edit_output_flyout';

function useSettingsAppData() {
const outputs = useGetOutputs();
Expand Down Expand Up @@ -124,9 +123,7 @@ export const SettingsApp = withConfirmModalProvider(() => {
</Route>
<Route path={FLEET_ROUTING_PATHS.settings_create_outputs}>
<EuiPortal>
<Suspense fallback={<EuiLoadingSpinner />}>
<EditOutputFlyout proxies={proxies.data.items} onClose={onCloseCallback} />
</Suspense>
<EditOutputFlyout proxies={proxies.data.items} onClose={onCloseCallback} />
</EuiPortal>
</Route>
<Route path={FLEET_ROUTING_PATHS.settings_create_fleet_proxy}>
Expand Down Expand Up @@ -158,13 +155,11 @@ export const SettingsApp = withConfirmModalProvider(() => {

return (
<EuiPortal>
<Suspense fallback={<EuiLoadingSpinner />}>
<EditOutputFlyout
proxies={proxies.data?.items ?? []}
onClose={onCloseCallback}
output={output}
/>
</Suspense>
<EditOutputFlyout
proxies={proxies.data?.items ?? []}
onClose={onCloseCallback}
output={output}
/>
</EuiPortal>
);
}}
Expand Down

0 comments on commit bd9979e

Please sign in to comment.