Skip to content

Commit

Permalink
[8.9] [Enterprise Search] Change minute values to preset intervals (#…
Browse files Browse the repository at this point in the history
…161082) (#161125)

# Backport

This will backport the following commits from `main` to `8.9`:
- [[Enterprise Search] Change minute values to preset intervals
(#161082)](#161082)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Efe Gürkan
YALAMAN","email":"efeguerkan.yalaman@elastic.co"},"sourceCommit":{"committedDate":"2023-07-03T16:24:51Z","message":"[Enterprise
Search] Change minute values to preset intervals (#161082)\n\n##
Summary\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/1410658/b9b7d66d-6368-4da4-90f6-2547193c07b6\r\n\r\n\r\nChange
minute values to the preset intervals\r\n5, 10, 15 and 30 minutes
presets are set.\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items
that are not applicable to this PR.\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[x] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"0aea720fb6002f49d90e0a06bc77eb0a13bff879","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.9.0","v8.10.0"],"number":161082,"url":"https://github.com/elastic/kibana/pull/161082","mergeCommit":{"message":"[Enterprise
Search] Change minute values to preset intervals (#161082)\n\n##
Summary\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/1410658/b9b7d66d-6368-4da4-90f6-2547193c07b6\r\n\r\n\r\nChange
minute values to the preset intervals\r\n5, 10, 15 and 30 minutes
presets are set.\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items
that are not applicable to this PR.\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[x] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"0aea720fb6002f49d90e0a06bc77eb0a13bff879"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161082","number":161082,"mergeCommit":{"message":"[Enterprise
Search] Change minute values to preset intervals (#161082)\n\n##
Summary\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/1410658/b9b7d66d-6368-4da4-90f6-2547193c07b6\r\n\r\n\r\nChange
minute values to the preset intervals\r\n5, 10, 15 and 30 minutes
presets are set.\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items
that are not applicable to this PR.\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[x] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"0aea720fb6002f49d90e0a06bc77eb0a13bff879"}}]}]
BACKPORT-->

Co-authored-by: Efe Gürkan YALAMAN <efeguerkan.yalaman@elastic.co>
  • Loading branch information
kibanamachine and efegurkan committed Jul 3, 2023
1 parent 8739470 commit c13daa2
Show file tree
Hide file tree
Showing 5 changed files with 37 additions and 815 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ function cronToFrequency(cron: string): Frequency {
if (fields.length < 4) {
return 'YEAR';
}
if (fields[1] === '*' || fields[1].startsWith('*/')) {
if (fields[1] === '*' || fields[1].includes(',')) {
return 'MINUTE';
}
if (fields[2] === '*') {
Expand Down

0 comments on commit c13daa2

Please sign in to comment.