Skip to content

Commit

Permalink
Enable extend from management
Browse files Browse the repository at this point in the history
  • Loading branch information
Liza K committed Feb 7, 2021
1 parent 8769c8d commit ca860a6
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 9 deletions.
4 changes: 2 additions & 2 deletions src/plugins/data/public/search/session/sessions_client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,9 @@ export class SessionsClient {
});
}

public extend(sessionId: string, keepAlive: string): Promise<SavedObjectsFindResponse> {
public extend(sessionId: string, expires: string): Promise<SavedObjectsFindResponse> {
return this.http!.post(`/internal/session/${encodeURIComponent(sessionId)}/_extend`, {
body: JSON.stringify({ keepAlive }),
body: JSON.stringify({ expires }),
});
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ const ExtendConfirm = ({
onCancel={onConfirmDismiss}
onConfirm={async () => {
setIsLoading(true);
await api.sendExtend(id, `${extendByDuration.asMilliseconds()}ms`);
await api.sendExtend(id, `${newExpiration.toISOString()}`);
setIsLoading(false);
onConfirmDismiss();
onActionComplete();
}}
confirmButtonText={confirm}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -178,11 +178,24 @@ export class SearchSessionsMgmtAPI {
}

// Extend
public async sendExtend(id: string, ttl: string): Promise<void> {
this.deps.notifications.toasts.addError(new Error('Not implemented'), {
title: i18n.translate('xpack.data.mgmt.searchSessions.api.extendError', {
defaultMessage: 'Failed to extend the session expiration!',
}),
});
public async sendExtend(id: string, expires: string): Promise<void> {
try {
await this.sessionsClient.extend(id, expires);

this.deps.notifications.toasts.addSuccess({
title: i18n.translate('xpack.data.mgmt.searchSessions.api.extended', {
defaultMessage: 'The search session was extended.',
}),
});
} catch (err) {
// eslint-disable-next-line no-console
console.error(err);

this.deps.notifications.toasts.addError(err, {
title: i18n.translate('xpack.data.mgmt.searchSessions.api.extendError', {
defaultMessage: 'Failed to extend the search session!',
}),
});
}
}
}

0 comments on commit ca860a6

Please sign in to comment.