Make usageCollection required because it doens't look like it can act…

…ually be disabled.
elastic · Apr 10, 2020 · cdf20e6 · cdf20e6
1 parent 24762dd
commit cdf20e6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/x-pack/plugins/index_lifecycle_management/kibana.json b/x-pack/plugins/index_lifecycle_management/kibana.json
@@ -4,12 +4,12 @@
   "server": true,
   "ui": true,
   "requiredPlugins": [
+    "usageCollection",
     "home",
     "licensing",
     "management"
   ],
   "optionalPlugins": [
-    "usageCollection",
     "indexManagement"
   ],
   "configPath": ["xpack", "ilm"]

diff --git a/x-pack/plugins/index_lifecycle_management/public/application/services/ui_metric.ts b/x-pack/plugins/index_lifecycle_management/public/application/services/ui_metric.ts
@@ -25,12 +25,8 @@ import { defaultColdPhase, defaultWarmPhase, defaultHotPhase } from '../store/de
 
 export let trackUiMetric: (metricType: UiStatsMetricType, eventName: string) => void;
 
-export function init(usageCollection: UsageCollectionSetup | undefined): void {
-  if (usageCollection) {
-    trackUiMetric = usageCollection.reportUiStats.bind(usageCollection, UIM_APP_NAME);
-  } else {
-    trackUiMetric = (metricType, eventName) => {};
-  }
+export function init(usageCollection: UsageCollectionSetup): void {
+  trackUiMetric = usageCollection.reportUiStats.bind(usageCollection, UIM_APP_NAME);
 }
 
 export function getUiMetricsForPhases(phases: any): any {

diff --git a/x-pack/plugins/index_lifecycle_management/public/types.ts b/x-pack/plugins/index_lifecycle_management/public/types.ts
@@ -9,7 +9,7 @@ import { ManagementSetup } from '../../../../src/plugins/management/public';
 import { IndexManagementPluginSetup } from '../../index_management/public';
 
 export interface PluginsDependencies {
-  usageCollection?: UsageCollectionSetup;
+  usageCollection: UsageCollectionSetup;
   management: ManagementSetup;
   indexManagement?: IndexManagementPluginSetup;
 }