Use double regex instead of if branch

elastic · May 8, 2024 · d09fcaa · d09fcaa
1 parent d653ab8
commit d09fcaa
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/...olution/observability_ai_assistant/server/service/client/operators/get_generated_title.ts b/...olution/observability_ai_assistant/server/service/client/operators/get_generated_title.ts
@@ -76,7 +76,7 @@ export function getGeneratedTitle({
       concatenateChatCompletionChunks(),
       last(),
       map((concatenatedMessage) => {
-        let title: string =
+        const title: string =
           (concatenatedMessage.message.function_call.name
             ? JSON.parse(concatenatedMessage.message.function_call.arguments).title
             : concatenatedMessage.message?.content) || '';
@@ -87,13 +87,8 @@ export function getGeneratedTitle({
         // - "Hello, World!" => Captures: Hello, World!
         // - 'Another Example' => Captures: Another Example
         // - JustTextWithoutQuotes => Captures: JustTextWithoutQuotes
-        if (
-          (title.startsWith(`"`) && title.endsWith(`"`)) ||
-          (title.startsWith(`'`) && title.endsWith(`'`))
-        ) {
-          title = title.substring(1, title.length - 1);
-        }
-        return title;
+
+        return title.replace(/^"(.*)"$/g, '$1').replace(/^'(.*)'$/g, '$1');
       }),
       tap((event) => {
         if (typeof event === 'string') {