[settings/indices] use settings-indices- prefix for tab direcives

elastic · Jun 2, 2016 · dc53a10 · dc53a10
1 parent 14d5458
commit dc53a10
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/src/plugins/kibana/public/settings/sections/indices/_edit.html b/src/plugins/kibana/public/settings/sections/indices/_edit.html
@@ -37,6 +37,7 @@
 
       <br />
 
+      <!-- tab list -->
       <ul class="nav nav-tabs">
         <li class="kbn-settings-tab" ng-repeat="tab in tabs" ng-class="{ active: state.tab === tab.index }">
           <a ng-click="changeTab(tab)">
@@ -46,8 +47,15 @@
         </li>
       </ul>
 
-      <indexed-fields ng-show="state.tab == 'indexedFields'" class="fields indexed-fields"></indexed-fields>
-      <scripted-fields ng-show="state.tab == 'scriptedFields'" class="fields scripted-fields"></scripted-fields>
+      <!-- tabs -->
+      <settings-indices-indexed-fields
+        ng-show="state.tab == 'indexedFields'"
+        class="fields indexed-fields">
+      </settings-indices-indexed-fields>
+      <settings-indices-scripted-fields
+        ng-show="state.tab == 'scriptedFields'"
+        class="fields scripted-fields">
+      </settings-indices-scripted-fields>
       <settings-indices-field-filters
         ng-show="state.tab == 'fieldFilters'"
         index-pattern="indexPattern"

diff --git a/src/plugins/kibana/public/settings/sections/indices/_indexed_fields.js b/src/plugins/kibana/public/settings/sections/indices/_indexed_fields.js
@@ -8,7 +8,7 @@ import indexedFieldsTemplate from 'plugins/kibana/settings/sections/indices/_ind
 import { fieldWildcardMatcher } from 'ui/field_wildcard';
 
 uiModules.get('apps/settings')
-.directive('indexedFields', function ($filter, config) {
+.directive('settingsIndicesIndexedFields', function ($filter) {
   const yesTemplate = '<i class="fa fa-check" aria-label="yes"></i>';
   const noTemplate = '';
   const filter = $filter('filter');

diff --git a/src/plugins/kibana/public/settings/sections/indices/_scripted_fields.js b/src/plugins/kibana/public/settings/sections/indices/_scripted_fields.js
@@ -7,7 +7,7 @@ import uiModules from 'ui/modules';
 import scriptedFieldsTemplate from 'plugins/kibana/settings/sections/indices/_scripted_fields.html';
 
 uiModules.get('apps/settings')
-.directive('scriptedFields', function (kbnUrl, Notifier, $filter) {
+.directive('settingsIndicesScriptedFields', function (kbnUrl, Notifier, $filter) {
   const rowScopes = []; // track row scopes, so they can be destroyed as needed
   const filter = $filter('filter');