Skip to content

Commit

Permalink
Add loader for kibana overview while checking for user data view (#11…
Browse files Browse the repository at this point in the history
…8881)

* add loader on overview page

* use KibanaThemeProvider for kibanaOverview

* change add data label to integrations

* adapt tests

* update snapshots, remove i18n keys

* review comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
  • Loading branch information
pgayvallet and kibanamachine committed Nov 19, 2021
1 parent 4eb797a commit e00de95
Show file tree
Hide file tree
Showing 9 changed files with 1,205 additions and 1,038 deletions.
31 changes: 18 additions & 13 deletions src/plugins/kibana_overview/public/application.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@ import React from 'react';
import ReactDOM from 'react-dom';
import { i18n } from '@kbn/i18n';
import { I18nProvider } from '@kbn/i18n/react';
import { KibanaContextProvider } from '../../../../src/plugins/kibana_react/public';
import {
KibanaContextProvider,
KibanaThemeProvider,
} from '../../../../src/plugins/kibana_react/public';
import { NewsfeedApiEndpoint } from '../../../../src/plugins/newsfeed/public';
import { AppMountParameters, CoreStart } from '../../../../src/core/public';
import { AppPluginStartDependencies } from './types';
Expand All @@ -19,7 +22,7 @@ import { KibanaOverviewApp } from './components/app';
export const renderApp = (
core: CoreStart,
deps: AppPluginStartDependencies,
{ appBasePath, element }: AppMountParameters
{ appBasePath, element, theme$ }: AppMountParameters
) => {
const { notifications, http } = core;
const { newsfeed, home, navigation } = deps;
Expand All @@ -37,17 +40,19 @@ export const renderApp = (

ReactDOM.render(
<I18nProvider>
<KibanaContextProvider services={{ ...core, ...deps }}>
<KibanaOverviewApp
basename={appBasePath}
notifications={notifications}
http={http}
navigation={navigation}
newsfeed$={newsfeed$}
solutions={solutions}
features={features}
/>
</KibanaContextProvider>
<KibanaThemeProvider theme$={theme$}>
<KibanaContextProvider services={{ ...core, ...deps }}>
<KibanaOverviewApp
basename={appBasePath}
notifications={notifications}
http={http}
navigation={navigation}
newsfeed$={newsfeed$}
solutions={solutions}
features={features}
/>
</KibanaContextProvider>
</KibanaThemeProvider>
</I18nProvider>,
element
);
Expand Down
Loading

0 comments on commit e00de95

Please sign in to comment.