[Discover] Fix flaky "Visualize text-based queries" test (#148400)

Closes #148225 100x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1701
elastic · Jan 5, 2023 · e955ddd · e955ddd
1 parent 19f5eff
commit e955ddd
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/x-pack/test/functional/apps/discover/visualize_field.ts b/x-pack/test/functional/apps/discover/visualize_field.ts
@@ -141,10 +141,11 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
 
       await testSubjects.click('textBased-visualize');
 
-      await retry.try(async () => {
+      await PageObjects.header.waitUntilLoadingHasFinished();
+
+      await retry.waitFor('lens visualization', async () => {
         const dimensions = await testSubjects.findAll('lns-dimensionTrigger-textBased');
-        expect(dimensions).to.have.length(2);
-        expect(await dimensions[1].getVisibleText()).to.be('average');
+        return dimensions.length === 2 && (await dimensions[1].getVisibleText()) === 'average';
       });
     });
 
@@ -159,10 +160,11 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
 
       await testSubjects.click('textBased-visualize');
 
-      await retry.try(async () => {
+      await PageObjects.header.waitUntilLoadingHasFinished();
+
+      await retry.waitFor('lens visualization', async () => {
         const dimensions = await testSubjects.findAll('lns-dimensionTrigger-textBased');
-        expect(dimensions).to.have.length(2);
-        expect(await dimensions[1].getVisibleText()).to.be('average');
+        return dimensions.length === 2 && (await dimensions[1].getVisibleText()) === 'average';
       });
     });
   });