fix useEffect unmount

elastic · Apr 2, 2024 · ede8504 · ede8504
1 parent 7db9bd4
commit ede8504
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/plugins/discover/public/application/main/components/top_nav/discover_topnav.tsx b/src/plugins/discover/public/application/main/components/top_nav/discover_topnav.tsx
@@ -200,10 +200,16 @@ export const DiscoverTopNav = ({
   ]);
 
   useEffect(() => {
-    console.log('time field', dataView?.getTimeField()?.spec.name);
     saveLsIndex(dataView?.getIndexPattern() || null);
     saveLsIndexTimeField(dataView?.getTimeField()?.spec.name || null);
     saveLsDataViewId(dataView?.id);
+
+    return () => {
+      saveLsIndex(null);
+      saveLsIndexTimeField(null);
+      saveLsDataViewId(null);
+    };
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [dataView]);
 
   const savedSearchId = useSavedSearch().id;