[ML] Disabling single metric viewer links for non-applicable jobs (#2…

…2809) (#22823) * [ML] Disabling single metric viewer links for non-applicable jobs * renaming variable * renaming variable again
elastic · Sep 7, 2018 · ee478de · ee478de
1 parent da0c398
commit ee478de
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/x-pack/plugins/ml/public/jobs/jobs_list/components/job_actions/results.js b/x-pack/plugins/ml/public/jobs/jobs_list/components/job_actions/results.js
@@ -40,9 +40,11 @@ function getLink(location, jobs) {
 
 export function ResultLinks({ jobs })  {
   const tooltipJobs = (jobs.length === 1) ? jobs[0].id : `${jobs.length} jobs`;
+  const singleMetricVisible = (jobs.length < 2);
+  const singleMetricEnabled = (jobs.length === 1 && jobs[0].isSingleMetricViewerJob);
   return (
     <React.Fragment>
-      {(jobs.length < 2) &&
+      {(singleMetricVisible) &&
         <EuiToolTip
           position="bottom"
           content={`Open ${tooltipJobs} in Single Metric Viewer`}
@@ -52,7 +54,7 @@ export function ResultLinks({ jobs })  {
             iconType="stats"
             aria-label="View results in single metric viewer"
             className="results-button"
-
+            isDisabled={(singleMetricEnabled === false)}
           />
         </EuiToolTip>
       }

diff --git a/x-pack/plugins/ml/server/models/job_service/jobs.js b/x-pack/plugins/ml/server/models/job_service/jobs.js
@@ -10,6 +10,7 @@ import { datafeedsProvider } from './datafeeds';
 import { jobAuditMessagesProvider } from '../job_audit_messages';
 import { CalendarManager } from '../calendar';
 import { fillResultsWithTimeouts, isRequestTimeout } from './error_utils';
+import { isTimeSeriesViewJob } from '../../../common/util/job_utils';
 import moment from 'moment';
 import { uniq } from 'lodash';
 
@@ -112,6 +113,7 @@ export function jobsProvider(callWithRequest) {
         datafeedState: (hasDatafeed && job.datafeed_config.state) ? job.datafeed_config.state : '',
         latestTimestampMs,
         earliestTimestampMs,
+        isSingleMetricViewerJob: isTimeSeriesViewJob(job),
         nodeName: (job.node) ? job.node.name : undefined,
       };
       if (jobIds.find(j => (j === tempJob.id))) {