use setScreenContext instead of PoC localStorage approach

src/plugins/discover/public/application/main/components/layout/discover_layout.tsx

@@ -136,12 +136,27 @@ export function DiscoverLayout({ stateContainer }: DiscoverLayoutProps) {
   });
 
   // The assistant is getting the state from the url correctly
-  // expect from the index pattern where we have only the dataview id
+  // except from the index pattern where we have only the dataview id.
   useEffect(() => {
+    const indexPattern = dataView?.getIndexPattern() || null;
+    const indexPatternTimeField = dataView?.getTimeField()?.spec.name || null;
+    const dataViewId = dataView?.id;
+
+    let indexPatternText =
+      'The current Elasticsearch index pattern could not be identified or the current page does not make use of an Elasticsearch index pattern.';
+
+    if (indexPattern !== null && indexPatternTimeField === null) {
+      indexPatternText = `The current Elasticsearch index is '${indexPattern}' and it has no time field specified.`;
+    } else if (indexPattern !== null && indexPatternTimeField !== null) {
+      indexPatternText = `The current Elasticsearch index is '${indexPattern}' and its time field is '${indexPatternTimeField}'.`;
+    }
+
+    const dataViewIdText = dataViewId ? ` The Kibana Data View Id is ${dataViewId}.` : '';
+
     return observabilityAIAssistant?.service.setScreenContext({
       screenDescription: `The user is looking at the Discover view on the ${
         isPlainRecord ? 'ES|QL' : 'dataView'
-      } mode. The index pattern is the ${dataView.getIndexPattern()}`,
+      } mode. ${indexPatternText}${dataViewIdText}`,
     });
   }, [dataView, isPlainRecord, observabilityAIAssistant?.service]);
 

src/plugins/discover/public/application/main/components/top_nav/discover_topnav.tsx

@@ -7,7 +7,6 @@
  */
 
 import React, { useCallback, useEffect, useMemo, useRef } from 'react';
-import { useLocalStorageListener } from '@kbn/ml-local-storage';
 import type { AggregateQuery, Query, TimeRange } from '@kbn/es-query';
 import { type DataView, DataViewType } from '@kbn/data-views-plugin/public';
 import { DataViewPickerProps } from '@kbn/unified-search-plugin/public';
@@ -79,16 +78,6 @@ export const DiscoverTopNav = ({
   const closeFieldEditor = useRef<() => void | undefined>();
   const closeDataViewEditor = useRef<() => void | undefined>();
 
-  const [lsIndex, saveLsIndex] = useLocalStorageListener('obs-ai-assistant-index', null);
-  const [lsDataViewId, saveLsDataViewId] = useLocalStorageListener(
-    'obs-ai-assistant-data-view-id',
-    null
-  );
-  const [lsIndexTimeField, saveLsIndexTimeField] = useLocalStorageListener(
-    'obs-ai-assistant-index-time-field',
-    null
-  );
-
   useEffect(() => {
     return () => {
       // Make sure to close the editors when unmounting
@@ -199,19 +188,6 @@ export const DiscoverTopNav = ({
     topNavMenu,
   ]);
 
-  useEffect(() => {
-    saveLsIndex(dataView?.getIndexPattern() || null);
-    saveLsIndexTimeField(dataView?.getTimeField()?.spec.name || null);
-    saveLsDataViewId(dataView?.id);
-
-    return () => {
-      saveLsIndex(null);
-      saveLsIndexTimeField(null);
-      saveLsDataViewId(null);
-    };
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [dataView]);
-
   const savedSearchId = useSavedSearch().id;
   const savedSearchHasChanged = useSavedSearchHasChanged();
   const dataViewPickerProps: DataViewPickerProps = useMemo(() => {

x-pack/packages/ml/local_storage/index.ts

@@ -6,4 +6,3 @@
  */
 
 export { StorageContextProvider, useStorage } from './src/storage_context';
-export { useLocalStorageListener } from './src/use_local_storage_listener';

x-pack/plugins/observability_solution/observability_ai_assistant_app/public/hooks/use_nav_control_screen_context.ts

@@ -8,7 +8,6 @@
 import { useEffect, useState } from 'react';
 import datemath from '@elastic/datemath';
 import moment from 'moment';
-import { useLocalStorageListener } from '@kbn/ml-local-storage';
 import { useKibana } from './use_kibana';
 import { useObservabilityAIAssistantAppService } from './use_observability_ai_assistant_app_service';
 
@@ -23,9 +22,6 @@ export function useNavControlScreenContext() {
     },
   } = useKibana();
 
-  const [lsIndex] = useLocalStorageListener('obs-ai-assistant-index', null);
-  const [lsDataViewId] = useLocalStorageListener('obs-ai-assistant-data-view-id', null);
-  const [lsIndexTimeField] = useLocalStorageListener('obs-ai-assistant-index-time-field', null);
   const { from, to } = data.query.timefilter.timefilter.getTime();
 
   const [href, setHref] = useState(window.location.href);
@@ -66,13 +62,8 @@ export function useNavControlScreenContext() {
     const start = datemath.parse(from)?.toISOString() ?? moment().subtract(1, 'day').toISOString();
     const end = datemath.parse(to)?.toISOString() ?? moment().toISOString();
 
-    const index =
-      lsIndex !== null && lsIndexTimeField !== null
-        ? `The current Elasticsearch index is '${lsIndex}' and its time field is '${lsIndexTimeField}'.`
-        : `The current Elasticsearch index could not be identified or the current page does not make use of an Elasticsearch index.`;
-
     return service.setScreenContext({
-      screenDescription: `The user is looking at ${href}. The current time range is ${start} - ${end}. ${index} The Kibana Data View Id is ${lsDataViewId}.`,
+      screenDescription: `The user is looking at ${href}. The current time range is ${start} - ${end}.`,
     });
-  }, [service, from, to, href, lsDataViewId, lsIndex, lsIndexTimeField]);
+  }, [service, from, to, href]);
 }