updating based on marcos feedback

elastic · Sep 12, 2018 · fa6b6d9 · fa6b6d9
1 parent 875e336
commit fa6b6d9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/test/functional/apps/visualize/_vertical_bar_chart.js b/test/functional/apps/visualize/_vertical_bar_chart.js
@@ -22,7 +22,6 @@ import expect from 'expect.js';
 export default function ({ getService, getPageObjects }) {
   const log = getService('log');
   const retry = getService('retry');
-  const find = getService('find');
   const PageObjects = getPageObjects(['common', 'visualize', 'header']);
 
   describe('vertical bar chart', function () {
@@ -291,11 +290,8 @@ export default function ({ getService, getPageObjects }) {
         await PageObjects.visualize.clickBucket('Split Series');
         await PageObjects.visualize.selectAggregation('Terms');
         await PageObjects.visualize.selectField('response.raw');
-        await PageObjects.header.waitUntilLoadingHasFinished();
 
-        const error = await find.byCssSelector('.vis-editor-agg-error');
-        const errorMessage = await error.getProperty('innerText');
-        log.debug(errorMessage);
+        const errorMessage = await PageObjects.visualize.getBucketErrorMessage();
         expect(errorMessage).to.contain('Last bucket aggregation must be "Date Histogram"');
       });
 

diff --git a/test/functional/page_objects/visualize_page.js b/test/functional/page_objects/visualize_page.js
@@ -1133,6 +1133,13 @@ export function VisualizePageProvider({ getService, getPageObjects }) {
       return await Promise.all(pieSlices.map(async pieSlice => await pieSlice.getAttribute('style')));
     }
 
+    async getBucketErrorMessage() {
+      const error = await find.byCssSelector('.vis-editor-agg-error');
+      const errorMessage = await error.getProperty('innerText');
+      log.debug(errorMessage);
+      return errorMessage;
+    }
+
     async selectSortMetric(agg, metric) {
       const sortMetric = await find.byCssSelector(`[data-test-subj="visEditorOrder${agg}-${metric}"]`);
       return await sortMetric.click();