Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack Monitoring] Create scoped issues for "All stack monitoring server routes use iots for type-safe validation" #102437

Closed
Tracked by #127224
jasonrhodes opened this issue Jun 16, 2021 · 5 comments
Assignees
Labels
chore Epic: Stack Monitoring TypeScript Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@jasonrhodes
Copy link
Member

jasonrhodes commented Jun 16, 2021

DEPENDS ON: #102436

AC:

  • This issue is broken into chunks representing the work needed to do the following:
    • all SM routes use iots
    • All types used for return values are moved to common/ so that the client can refer to them too
@jasonrhodes jasonrhodes added chore Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Epic: Stack Monitoring TypeScript labels Jun 16, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@jasonrhodes jasonrhodes changed the title [Stack Monitoring] All stack monitoring server routes use iots for type-safe validation [Stack Monitoring] Create scoped issues for "All stack monitoring server routes use iots for type-safe validation" Mar 9, 2022
@weltenwort
Copy link
Member

The light-weight approach with io-ts that we use in the infra plugin worked out well. Here's the original demo PR that I created to pitch the convention: weltenwort#2

@smith
Copy link
Contributor

smith commented Mar 9, 2022

Might be worth looking at @kbn/server-route-repository. @dgieselaar extracted this from APM and might have some idea about the amount of effort it would take for us to use it.

@Kerry350 Kerry350 self-assigned this Apr 12, 2022
@Kerry350
Copy link
Contributor

I've assigned this as it crosses over with some work I've done in #117756 so it makes most sense for me to refine this.

@Kerry350
Copy link
Contributor

Closing this in favour of an AC on the route conversion issues, rather than more scoped issues: #127224 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Epic: Stack Monitoring TypeScript Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

No branches or pull requests

5 participants