Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out fields containing * in their name from field_caps #110007

Closed
timroes opened this issue Aug 25, 2021 · 2 comments
Closed

Filter out fields containing * in their name from field_caps #110007

timroes opened this issue Aug 25, 2021 · 2 comments
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@timroes
Copy link
Contributor

timroes commented Aug 25, 2021

Currently you can have fields in Elasticsearch containing * as a name. Those fields though will not behave very well across ES APIs since the * is treated as a wildcard in most APIs and thus will cause a wide range of problems, from e.g. us asking for date formatting on a field containing a * will accidentally ask for date formatting on all fields matching that wild card, which might not all be date fields and thus throw errors.

ES is considering disallowing fields containing * altogether: elastic/elasticsearch#76874

Since that will still require people who might have run into that issue to require reindexing their data to get rid of those fields from the mapping, I wanted to discuss if we simply want to filter out fields containing * when reading the _field_caps response (a simple if (fieldName.includes('*')) return; in field_caps_response.ts).

cc @nik9000

@timroes timroes added Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:AppServices labels Aug 25, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Sep 11, 2021
@petrklapka
Copy link
Member

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@petrklapka petrklapka closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Development

No branches or pull requests

3 participants