Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't prompt to overwrite saved objects if import file can't be parsed #11057

Closed
w33ble opened this issue Apr 5, 2017 · 1 comment
Closed

Don't prompt to overwrite saved objects if import file can't be parsed #11057

w33ble opened this issue Apr 5, 2017 · 1 comment
Assignees
@w33ble
Labels
bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit PR sent

Comments

@w33ble
Copy link
Contributor

w33ble commented Apr 5, 2017

As noted in this comment on 5694, then importing an invalid file in Settings > Objects > Import, the user will be prompted about overwriting all existing objects by default even when parsing the file fails:

Instead, the dialog shouldn't even appear if parsing fails.
@w33ble w33ble added :Management bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit labels Apr 5, 2017
@w33ble w33ble mentioned this issue Apr 5, 2017
Closed
@w33ble w33ble self-assigned this Apr 5, 2017
@w33ble w33ble mentioned this issue Apr 5, 2017
Merged
@w33ble w33ble added the PR sent label Apr 5, 2017
@chrisronline
Copy link
Contributor

Closed by #11059

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@w33ble w33ble

Labels
bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit PR sent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisronline @w33ble