Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alerting] Remove export* syntax from plugin index files #110895

Open
spalger opened this issue Sep 1, 2021 · 1 comment
Open

[alerting] Remove export* syntax from plugin index files #110895

spalger opened this issue Sep 1, 2021 · 1 comment
Labels
chore estimate:small Small Estimated Level of Effort Feature:Actions Feature:Alerting Feature:EventLog Feature:Task Manager Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@spalger
Copy link
Contributor

spalger commented Sep 1, 2021

See #57370 for reasoning, but the gist is that export * usage leads to unexpected and excessive exports from the plugin, leading the public API to grow and increasing the cost of maintaining backwards compatibility.

#109357 implements an ESLint rule to check for this that also assists in fixing the rule, though the auto-fix is imperfect and will require some manual review before committing.

Please remove the /* eslint-disable @kbn/eslint/no_export_all */ comment(s) added in #109357 from the relevant files, validate the auto-fix, remove unnecessary exports, and then submit a PR. Thank you!

Hint: You can search for the URL of this issue to find specific occurrences

@spalger spalger added chore Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Sep 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@gmmorris gmmorris added Feature:Actions Feature:Alerting Feature:EventLog Feature:Task Manager estimate:small Small Estimated Level of Effort technical debt Improvement of the software architecture and operational architecture and removed technical debt Improvement of the software architecture and operational architecture labels Sep 2, 2021
@mikecote mikecote added this to Backlog in Kibana Alerting Sep 8, 2021
@XavierM XavierM removed this from Backlog in Kibana Alerting Jan 6, 2022
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore estimate:small Small Estimated Level of Effort Feature:Actions Feature:Alerting Feature:EventLog Feature:Task Manager Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Development

No branches or pull requests

4 participants