Eslint rule forbidding top level export *

[stacey-gammon]

The app arch team, and I think the platform team, have both decided that the "best practice" for top level exports, at public/index.ts and server/index.ts should use explicit exports only.

This will help ensure interfaces don't accidentally leak into the public contract.

It'd be great if we could right an es lint rule for this as it'd be nice to enforce all teams follow this.

---

Completion status: https://github.com/elastic/kibana/projects/76

[elasticmachine]

Pinging @elastic/kibana-platform (Team:Platform)

[elasticmachine]

Pinging @elastic/kibana-operations (Team:Operations)

[stacey-gammon]

We've added this rule into our style guide, but ideally it would be linted on. (https://github.com/elastic/kibana/blob/master/STYLEGUIDE.mdx#avoid-export--in-top-level-indexts-files)

Any thoughts on whether this could be prioritized?

[mshustov]

Any thoughts on whether this could be prioritized?

Do you want only Core and AppServices teams to adopt this rule? Maybe we should combine this effort with other linting issues into a single project (I suspect this one #74385 will create a lot of noise)?

[stacey-gammon]

I think everyone contributing code to Kibana should adopt the rule.

If you think it will be more effective to combine with that issue, sounds good to me!

[mshustov]

If you think it will be more effective to combine with that issue, sounds good to me!

I think it might reduce the communication overhead for all the linter changes. A team can fix several of them at once since most of them are quite trivial.
But realistically, it might be postponed until 8.0?

[rudolf]

We support this proposal but implementing this does not feel like a good fit for the Core team's responsibilities so removing the Core team's assignment.

@tylersmalley not sure if removing the operations team was intentional? Should we close the issue if no one is planning on working on it?

[drewdaemon]

Sent back to the operations team. Feel free to close if it is not an issue you'll be addressing.