Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rac] Remove export* syntax from plugin index files #110907

Open
spalger opened this issue Sep 1, 2021 · 1 comment
Open

[rac] Remove export* syntax from plugin index files #110907

spalger opened this issue Sep 1, 2021 · 1 comment
Labels
chore Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Theme: rac label obsolete

Comments

@spalger
Copy link
Contributor

spalger commented Sep 1, 2021

See #57370 for reasoning, but the gist is that export * usage leads to unexpected and excessive exports from the plugin, leading the public API to grow and increasing the cost of maintaining backwards compatibility.

#109357 implements an ESLint rule to check for this that also assists in fixing the rule, though the auto-fix is imperfect and will require some manual review before committing.

Please remove the /* eslint-disable @kbn/eslint/no_export_all */ comment(s) added in #109357 from the relevant files, validate the auto-fix, remove unnecessary exports, and then submit a PR. Thank you!

Hint: You can search for the URL of this issue to find specific occurrences

@spalger spalger added chore Theme: rac label obsolete labels Sep 1, 2021
@spalger spalger added this to Pending in Remove export* syntax from plugin index files via automation Sep 1, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 1, 2021
@spalger spalger added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Theme: rac label obsolete
Development

No branches or pull requests

2 participants