Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Kibana shouldn't display actionable back and cancel buttons on file upload page once upload goes through #112285

Closed
bhavyarm opened this issue Sep 15, 2021 · 8 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:File and Index Data Viz ML file and index data visualizer :ml Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v8.9.0

Comments

@bhavyarm
Copy link
Contributor

Kibana version: 7.15.0 BC6

Elasticsearch version: 7.15.0 BC6

Server OS version: darwin_x86_64

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: Kibana displays actionable back and cancel methods on file upload page even after the upload goes through. Clicking them doesn't mean anything after this stage.

Can we either grey them out or display success messages instead?

file_upload

@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. :ml labels Sep 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design (Team:Kibana-Design)

@bhavyarm
Copy link
Contributor Author

I am not sure who owns file upload anymore. Pinging design and ml team. Apologies for the extra pings.

@peteharverson peteharverson added the Feature:File and Index Data Viz ML file and index data visualizer label Sep 15, 2021
@peteharverson peteharverson changed the title Kibana shouldn't display actionable back and cancel buttons on file upload page once upload goes through [ML] Kibana shouldn't display actionable back and cancel buttons on file upload page once upload goes through Sep 15, 2021
@jgowdyelastic
Copy link
Member

I agree that Cancel is confusing here, as the action has already happened, so how can you cancel it.
The action it performs however is useful, it takes the user back to the file section screen so they can upload a new file. So maybe the Cancel button should be renamed or we should have a different button/link to take the user back to the file select screen.

The Back button is ok here IMO, it takes the user back to the previous screen where they can adjust overrides and then reimport the same file.

I use both of these buttons/actions after import all of the time as i'm often testing import configurations and trying different files. But as a developer of the tool I might have unusual use cases.

@bhavyarm
Copy link
Contributor Author

The action it performs however is useful, it takes the user back to the file section screen so they can upload a new file. So maybe the Cancel button should be renamed or we should have a different button/link to take the user back to the file select screen.

Renaming that button to reduce the confusion would be great.

May be we can rename both buttons? Thanks!

@peteharverson
Copy link
Contributor

This has come up again. Perhaps the Cancel button could be changed for a Upload another file ?

@mdefazio
Copy link
Contributor

I'm wondering if we move these actions to within the content portion (and remove the bottom bar). We rename them as stated above, but they would live next to the previous 'Import' button. (After import, labeled 'Reset').

Then we can rename all of these so they're a bit clearer as to what they will do.

[Change index] [Change import settings] [Cancel / Import another file] (All in the same row).

"Change" is probably not the best choice here. cc/ @szabosteve

Granted we would still have the bottom bar in the first Import step. But beyond this, all these actions are now grouped together. (And bottom bar can be removed altogether).

I'm assuming the typical next step for users would be to jump into Discover, or the other cards. So perhaps this block also moves up and appears above the buttons. For me when I went through it, I had to scroll down to see these. This move would instead force these cards into view.

Here's a hacked together example showing the changes. Note that I also removed the extra shadows around the panels. If we combine these sections, I think that's an important step so the visual noise around these actions is reduced.

image

image

@jgowdyelastic jgowdyelastic self-assigned this May 2, 2023
jgowdyelastic added a commit that referenced this issue Jun 20, 2023
Relates to #112285

Removes the black bar at the bottom of the app which housed the import
and cancel buttons.

Rather than having a button called "Change import settings" I've left
this as the "Back" button. "Change import settings" isn't really a
correct description of the page the button returns you to. Something
like "Rerun analysis of the already selected file" would be accurate,
but that is too long for a button.

@mdefazio Does this look ok? Any other suggestions? Note, I'd like to
keep this PR small, the main aim was just to remove the black bar at the
bottom of the page and change the name of the Cancel button after the
import has already run.


![image](https://github.com/elastic/kibana/assets/22172091/9fc77009-6690-4a6f-9845-800d2486da23)



![image](https://github.com/elastic/kibana/assets/22172091/f986d0dd-1f3a-4cda-b715-e7a1a56e8cb6)



![image](https://github.com/elastic/kibana/assets/22172091/c24c9358-fa36-4e78-b5df-216c0dd3e734)
@peteharverson
Copy link
Contributor

Closing as addressed by #159722 for 8.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:File and Index Data Viz ML file and index data visualizer :ml Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v8.9.0
Projects
None yet
Development

No branches or pull requests

5 participants