Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: Timelion expression input #11533

Closed
cjcenizal opened this issue Apr 28, 2017 · 0 comments
Closed

Accessibility: Timelion expression input #11533

cjcenizal opened this issue Apr 28, 2017 · 0 comments
Assignees
@timroes
Labels
bug Fixes for quality problems that affect the customer experience Feature:Timelion Timelion app and visualization Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Project:Accessibility Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@cjcenizal
Copy link
Contributor

Problem

The autocomplete feature (see screenshot below) is not accessible to screen reader and keyboard users. A functioning autocomplete field does the following:

  • It should announce the presence of autocomplete.
  • It must announce the number of available options, and this information must be updated dynamically as these options changes.
  • It must announce the options as the user navigates through them with the arrow keys.

The field has aria-label="Search" and placeholder="Search…". If there is even a slight mismatch between these two values, a screen reader will probably read them both. If the placeholder text and label present the same information, they should match exactly.
@cjcenizal cjcenizal added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Apr 28, 2017
@cjcenizal cjcenizal mentioned this issue Apr 28, 2017
Closed
38 tasks
@cjcenizal cjcenizal added Feature:Timelion Timelion app and visualization Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Project:Accessibility labels May 17, 2017
@cjcenizal cjcenizal mentioned this issue Jun 6, 2017
Closed
20 tasks
@tbragin tbragin added the bug Fixes for quality problems that affect the customer experience label Jul 28, 2017
@timroes timroes self-assigned this Aug 16, 2017
timroes pushed a commit to timroes/kibana that referenced this issue Aug 16, 2017
Make timelion autocompletion properly accessible
ac23676 
Fixes elastic#11533, fixes elastic#11525, fixes elastic#12908
This was referenced Aug 16, 2017
Merged
Closed
timroes added a commit that referenced this issue Aug 21, 2017
@timroes
Improve timelion accessibility (#13531)
529a9e3 
* Fix broken refresh shortcut for non OS X

On non OS X systems, the e.metaKey is most likely the windows key.
Hotkeys with the windows key are usually used as global (non application
internal) hotkeys. Also the documentation states, that Ctrl + Enter
should also work. With this commit it doesn't matter whether you press
the Meta or the Ctrl key + Enter.

* Make timelion datepicker more accessible

* Add meaningful labels to each interval shortcut, and
* Add a proper label to the custom input text field

* Make save options keyboard accessible, fix #12246, fix #12487

* Make sort button of saved-object-finder accessible, fix #12486

* Label timelion options correctly, fix #12907

* Make timelion legends keyboard accessible, fix #11844

* Make timelion autocompletion properly accessible

Fixes #11533, fixes #11525, fixes #12908

* Make timelion charts and actions accessible, fix #12909

* Add some more inline comments

* Fix HTML styles according to styleguide

* Replace sr-only by kuiScreenReaderOnly

* Make timelion autocompletion work with ARIA 1.1
timroes added a commit that referenced this issue Aug 21, 2017
@timroes
Improve timelion accessibility (#13531)
904bda9 
* Fix broken refresh shortcut for non OS X

On non OS X systems, the e.metaKey is most likely the windows key.
Hotkeys with the windows key are usually used as global (non application
internal) hotkeys. Also the documentation states, that Ctrl + Enter
should also work. With this commit it doesn't matter whether you press
the Meta or the Ctrl key + Enter.

* Make timelion datepicker more accessible

* Add meaningful labels to each interval shortcut, and
* Add a proper label to the custom input text field

* Make save options keyboard accessible, fix #12246, fix #12487

* Make sort button of saved-object-finder accessible, fix #12486

* Label timelion options correctly, fix #12907

* Make timelion legends keyboard accessible, fix #11844

* Make timelion autocompletion properly accessible

Fixes #11533, fixes #11525, fixes #12908

* Make timelion charts and actions accessible, fix #12909

* Add some more inline comments

* Fix HTML styles according to styleguide

* Replace sr-only by kuiScreenReaderOnly

* Make timelion autocompletion work with ARIA 1.1
chrisronline pushed a commit to chrisronline/kibana that referenced this issue Nov 20, 2017
@timroes @chrisronline
Improve timelion accessibility (elastic#13531)
b686f2e 
* Fix broken refresh shortcut for non OS X

On non OS X systems, the e.metaKey is most likely the windows key.
Hotkeys with the windows key are usually used as global (non application
internal) hotkeys. Also the documentation states, that Ctrl + Enter
should also work. With this commit it doesn't matter whether you press
the Meta or the Ctrl key + Enter.

* Make timelion datepicker more accessible

* Add meaningful labels to each interval shortcut, and
* Add a proper label to the custom input text field

* Make save options keyboard accessible, fix elastic#12246, fix elastic#12487

* Make sort button of saved-object-finder accessible, fix elastic#12486

* Label timelion options correctly, fix elastic#12907

* Make timelion legends keyboard accessible, fix elastic#11844

* Make timelion autocompletion properly accessible

Fixes elastic#11533, fixes elastic#11525, fixes elastic#12908

* Make timelion charts and actions accessible, fix elastic#12909

* Add some more inline comments

* Fix HTML styles according to styleguide

* Replace sr-only by kuiScreenReaderOnly

* Make timelion autocompletion work with ARIA 1.1
chrisronline pushed a commit to chrisronline/kibana that referenced this issue Dec 1, 2017
@timroes @chrisronline
Improve timelion accessibility (elastic#13531)
0101e42 
* Fix broken refresh shortcut for non OS X

On non OS X systems, the e.metaKey is most likely the windows key.
Hotkeys with the windows key are usually used as global (non application
internal) hotkeys. Also the documentation states, that Ctrl + Enter
should also work. With this commit it doesn't matter whether you press
the Meta or the Ctrl key + Enter.

* Make timelion datepicker more accessible

* Add meaningful labels to each interval shortcut, and
* Add a proper label to the custom input text field

* Make save options keyboard accessible, fix elastic#12246, fix elastic#12487

* Make sort button of saved-object-finder accessible, fix elastic#12486

* Label timelion options correctly, fix elastic#12907

* Make timelion legends keyboard accessible, fix elastic#11844

* Make timelion autocompletion properly accessible

Fixes elastic#11533, fixes elastic#11525, fixes elastic#12908

* Make timelion charts and actions accessible, fix elastic#12909

* Add some more inline comments

* Fix HTML styles according to styleguide

* Replace sr-only by kuiScreenReaderOnly

* Make timelion autocompletion work with ARIA 1.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timroes timroes

Labels
bug Fixes for quality problems that affect the customer experience Feature:Timelion Timelion app and visualization Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Project:Accessibility Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timroes @tbragin @cjcenizal