Show line not working in Dashboard.

[rashmivkulkarni]

Kibana version: master 6.0 alpha1

Elasticsearch version: master 6.0 alpha1

Server OS version: OSX

Browser version: Chrome

Original install method (e.g. download page, yum, from source, etc.): running master builds

Description of the problem including expected versus actual behavior: If you have unchecked the show line in line chart then saved the same and when you open it in dashboard the line is still visible. ( reproduced this on 5.4 and master )

Steps to reproduce:

1. Create a line chart viz and uncheck show line in Metrics and Axes > save.
2. Add the same viz to a dashboard.
   3.Now see that the line is visible in the dashboard . It should NOT be.

[stacey-gammon]

@ppisljar You may have to help me out with this. You can also get the setting to not be abided in Visualize by navigating back to Visualize after navigating to the visualization on a dashboard:

The problem seems to happen in VislibVisTypeVislibVisTypeProvider, in the updateParams function. I'm not sure the point of this function, but there are two duplicate sets of values in the vis.params object - one on vis.params itself, and one on vis.params.seriesParams. This function copies the ones in vis.params to vis.params.seriesParams. But as far as I can tell, the ones that are accurate are the one seriesParams, and the correct values are being overwritten.

I'm assuming the same issue exists for interpolate which is also a duplicate setting.

The only reason it works when opening up the visualization fresh is because updateVisAggs(); ends up being called in $scope.$watchCollection('vis.params', prereq(function () {. This puts the right values back in the seriesParam object (after they were initially overwritten by the updateParams function).

Since I don't understand the reasoning for this logic, I'm going to stop investigating and wait for @ppisljar to weigh in. Otherwise I'm afraid I'll end up changing something that is there for a reason.

[ppisljar]

@stacey-gammon a PR to fix this is already up: #11958 (i think it will fix this as well) ... seems i need to fix some tests

[ppisljar]

the updateParams shoud convert from pre 5.2 configuration to 5.2 .... however once this happens it was not removing the old config ...

[ppisljar]

closed by #11958

[ericyeh1995]

It seems like I have the same issue with line mode and show circles. Is it fixed on 6.0.0-alpha2?

[ppisljar]

@ericyeh1995 yes it should be