Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting to exclude the Header/Footer when generating iFrame code to share a Dashboard #121041

Closed
Tracked by #168126
EricPSU opened this issue Dec 10, 2021 · 6 comments
Closed
Tracked by #168126
Labels
Feature:Dashboard Dashboard related features Feature:SharingURLs Short URLs and Share URL features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@EricPSU
Copy link

EricPSU commented Dec 10, 2021

Issue #17298 introduced a configurable option to create a header (and soon footer) that persists on all screens in Kibana.

Requesting the ability to exclude this header/footer from the "Include" portion of the embed options when generating iFrame code to share a dashboard.

image

@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 10, 2021
@kertal kertal added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Dec 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 15, 2021
@ThomThomson ThomThomson added loe:large Large Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed triage_needed labels Jun 20, 2022
@ThomThomson
Copy link
Contributor

@mbarretta, have you heard of other use-cases that would require not displaying the header / footer in reports?

@EricPSU
Copy link
Author

EricPSU commented Sep 28, 2022

@ThomThomson I didn't see this comment back in June, but I can try to give more context. I assume @mbarretta would say the same since he is supporting customers with the same requirements.

For some Federal customers, we need to have a header/footer on all pages of ALL websites. In the case of Kibana, that's being worked in issue #17298. BUT, we also want to be able to embed something like a Kibana dashboard within an existing webpage that already has a banner. While on its face, that's simply an odd experience, it also might not be compliant b/c the webpage that you are embedding into might have different banner requirements than Kibana, therefore those banners would conflict with each other. hence this requirement, enable a toggle that would show/hide the header/footer when embedding.

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features Feature:SharingURLs Short URLs and Share URL features labels Sep 28, 2022
@ThomThomson
Copy link
Contributor

Thanks for the context! I'm not sure when we can prioritize this, but I've added the appropriate tags.

@mbarretta
Copy link

Ditto @EricPSU on both: apologies for missing the comment in June and with respect to preventing the embedded component from duplicating header/footers that conflict with those on the "host" app

@ThomThomson
Copy link
Contributor

Closing this for the time being. It will be tracked in our Icebox for Iframe / Embedding issues and will be re-opened if our priorities change.

@ThomThomson ThomThomson closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features Feature:SharingURLs Short URLs and Share URL features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

5 participants