Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Runtime Fields] UX: Runtime Field Promotion v1 #123828

Closed
5 tasks done
Tracked by #166175 ...
mdefazio opened this issue Jan 26, 2022 · 8 comments
Closed
5 tasks done
Tracked by #166175 ...

[Runtime Fields] UX: Runtime Field Promotion v1 #123828

mdefazio opened this issue Jan 26, 2022 · 8 comments
Assignees
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Runtime Fields impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects

Comments

@mdefazio
Copy link
Contributor

mdefazio commented Jan 26, 2022

Runtime Field Promotion UX issue

Single field promotion

Focused on system administrator that knows which field to promote, we will simply provide an extra option on the table to promote a single field to the index template.


Project links:

Project doc
Design doc
Whimsical flow Outdated
Video Walkthrough Outdated
Figma Prototype
Figma Mockups

Tasks:

  • Create design doc
  • Create user flows (2 options)
  • Create clickable prototype
  • Create mockups
  • Finalize design spec

Designs

Table updates with promote link next to runtime fields badge

Add tooltip over runtime field badge noting a data view runtime field (vs a index template rtf)

image

Promote to index template modal

Modal with warning about trade-offs of promoting to index template with a follow-up confirmation step. Selected field block will need to be updated in later phases to show multiple field selection

image

image

Promoted field in table

Runtime field now attached to index template and no longer shows 'Promote' link as well as delete icon. Note: Flyout would now also only show Custom label and Format

image


Screenflow

Screen Recording 2022-03-18 at 10 21 04 AM

@mdefazio mdefazio self-assigned this Jan 26, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Jan 26, 2022
@mdefazio mdefazio added Feature:Runtime Fields needs-team Issues missing a team label Team:AppServicesUx and removed needs-team Issues missing a team label labels Jan 26, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@mdefazio
Copy link
Contributor Author

@sixstringcode @ryankeairns I've updated this user flow to show a second option that allows promotion to be accessible from outside the flyout. This will also avoid needing to do all the extra steps in the editing flyout (which I think will likely lead to a clunky experience). Curious to get your thoughts though. Further rationale within the whimsical doc.

@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort labels Feb 1, 2022
@mdefazio
Copy link
Contributor Author

mdefazio commented Feb 2, 2022

@ryankeairns @lockewritesdocs @sixstringcode @mattkime @petrklapka I've added in a rough promotion prototype. This still needs some help from a copy standpoint and the modal itself could likely use some clean-up. But I'm hoping this will be enough to help drive some conversations.

(Prototype linked in issue description)

@mdefazio mdefazio changed the title Runtime Fields UX: Runtime Field Promotion v1 [Runtime Fields] UX: Runtime Field Promotion v1 Feb 3, 2022
@mdefazio
Copy link
Contributor Author

mdefazio commented Feb 4, 2022

In regards to the extra confirmation step: noticed that switching from APM binary to Elastic agent feels like a similar pattern. There is a checkbox to confirm within the modal—likely a nice addition for RTF promotion.

Copy from switching APM server to Elastic agent just for visibility:

We have created a simple and seamless process for switching from APM Server binary to Elastic Agent. Beware this action is irreversible and can only be performed by a superuser with access to Fleet. Learn more about [Elastic Agent]

@mdefazio
Copy link
Contributor Author

@mattkime @sixstringcode @ryankeairns I have updated this issue with design links and a new prototype walkthrough.

Updates:

  • Simplify promote link on field list table to simply be a link next to runtime field badge: This is the most straightforward update without modifying the rest of the table
  • Add tooltips to runtime field badge next to field name (to help clarify between data view rtf and index template rtf)
  • Updated modal that references only a single field selection. Note that this will need to be updated when we add selection to the field table.
  • Add in a confirmation modal since this is an irreversible action
  • Toast message confirming promote action completed.
    • Removes 'promote' link next to field name and removes trash icon from actions. Again, just noting that this would also disable the 'Set value' portion of the field flyout, similar to other indexed fields.

@ryankeairns
Copy link
Contributor

Per Jason, they've received some feedback from the Elasticsearch team that is causing them to reconsider the approach here. For that reason, it is currently 'paused'. Graceful failure will be a higher priority in the near term.

@petrklapka petrklapka added Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) and removed Team:AppServicesUx labels Nov 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kibanamachine kibanamachine added this to Inbox in Discover Nov 28, 2022
@kertal kertal added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Feb 28, 2023
@kertal
Copy link
Member

kertal commented Oct 24, 2023

Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.

@kertal kertal closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Runtime Fields impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
No open projects
Development

No branches or pull requests

5 participants