Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Do not allow to use logstash output with APM integration #125994

Closed
Tracked by #104987
nchaulet opened this issue Feb 17, 2022 · 8 comments · Fixed by #127809
Closed
Tracked by #104987

[Fleet] Do not allow to use logstash output with APM integration #125994

nchaulet opened this issue Feb 17, 2022 · 8 comments · Fixed by #127809
Assignees
Labels
QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team v8.2.0

Comments

@nchaulet
Copy link
Member

Description

Related to #104987

The APM integration is not compatible with the logstash output type we should not allow user to use a logstash output with that integration.

Test plan

The following scenarios should be covered:

  • It's not possible to add APM to a policy using the default data output if the default data output type is logstash
  • It's not possible to add APM to a policy using a logstash output as data output.
  • It's not possible to make a logstash output the default data output if an agent policy using the default data output contains APM.
@nchaulet nchaulet added Team:Fleet Team label for Observability Data Collection Fleet team v8.2.0 labels Feb 17, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@joshdover
Copy link
Contributor

Don't we need to do something similar for policies with a Fleet Server integration policy? cc @mostlyjason

@nchaulet
Copy link
Member Author

nchaulet commented Mar 3, 2022

Don't we need to do something similar for policies with a Fleet Server integration policy? cc @mostlyjason

I think Fleet server should be able to run with a policy with a logstash output as we pass the ES output as an argument to Fleet server with --fleet-server-es, ... cc @lykkin

@lykkin
Copy link
Contributor

lykkin commented Mar 3, 2022

yeah, fleet server doesn't actually get its output information from the usual agent pipeline.

not sure if it's being tracked, but endpoint also doesn't support logstash and should be treated similarly.

@nchaulet
Copy link
Member Author

nchaulet commented Mar 3, 2022

not sure if it's being tracked, but endpoint also doesn't support logstash and should be treated similarly.

@brian-mckinney is working on the implementation for endpoint so it should not be a problem.

@amolnater-qasource
Copy link

Hi @nchaulet
We have revalidated this issue on latest 8.2 Snapshot and the feature is working as expected:

  • We are not able to add APM integration when policy is set to Logstash output.
  • We are not able to add APM integration when policy is set to Default (Currently Logstash Output).
  • When APM integration is added we are not able to set output to Logstash under Policy settings.
  • When APM integration is added we are not able to set Logstash output to Default under Add Output Settings.

Build details:
BUILD: 51835
COMMIT: 6fcd2d0

Screenshots:
15
16
14

Hence marking this as QA:Validated.
Further we will be creating test content for the same.
Thanks

@amolnater-qasource amolnater-qasource added the QA:Validated Issue has been validated by QA label Apr 12, 2022
@amolnater-qasource
Copy link

Hi Team
We have executed 04 testcases for this feature under our Fleet Test plan at links:

Thanks

@amolnater-qasource amolnater-qasource removed the QA:Needs Validation Issue needs to be validated by QA label May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team v8.2.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants