Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Do not allow to use logstash output with APM integration #127809

Merged
merged 7 commits into from
Mar 21, 2022
Merged

[Fleet] Do not allow to use logstash output with APM integration #127809

merged 7 commits into from
Mar 21, 2022

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Mar 15, 2022 •
edited
Loading

Summary

Resolve #125994

APM integration do not support the logstash output type, that PR enforce that, in Fleet API and in Fleet UI.

UI Changes

When changing output for an agent policy that use APM

Screen Shot 2022-03-17 at 11 05 56 AM

When adding APM to an agent policy using logstash

Screen Shot 2022-03-17 at 10 31 44 AM

@nchaulet nchaulet added Team:Fleet Team label for Observability Data Collection Fleet team v8.2.0 labels Mar 15, 2022
@nchaulet nchaulet self-assigned this Mar 15, 2022
@nchaulet nchaulet marked this pull request as ready for review March 18, 2022 13:19
@nchaulet nchaulet requested a review from a team as a code owner March 18, 2022 13:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Mar 18, 2022
juliaElastic
juliaElastic approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 676.3KB 678.4KB +2.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit 2c6c935 into elastic:main Mar 21, 2022
@nchaulet nchaulet deleted the feature-logstash-apm branch March 21, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaElastic juliaElastic juliaElastic approved these changes

Assignees

@nchaulet nchaulet

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet] Do not allow to use logstash output with APM integration
5 participants
@nchaulet @elasticmachine @kibana-ci @juliaElastic @kibanamachine