Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Additional time series metric metadata in field list #130726

Closed
ghudgins opened this issue Apr 20, 2022 · 7 comments
Closed

[Lens] Additional time series metric metadata in field list #130726

ghudgins opened this issue Apr 20, 2022 · 7 comments
Assignees
Labels
enhancement New value added to drive a business result Feature:Lens impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects

Comments

@ghudgins
Copy link

ghudgins commented Apr 20, 2022

Describe the feature: Surface additional metadata in the field list for pure mode: time_series data views

Design ideas:
Filter by type idea
Add metric subclassifications to "Type" selector. Instead of number offer Gauge metrics Rate metrics etc...

Field list sections idea
image

Add field breakdown sections to the fields that have values. Note from dev: they can only afford 1 level of grouping in the field list. There is some weirdness with this one seeing that there would be no easy way to see fields in alphabetical order as they are today although maybe we could duplicate the info? Might want to validate this is useful but I do think surfacing metrics at the top of Lens would be most useful for metric data.

Desired order:

  • Metrics
  • Dimensions
  • Other fields

Fallback support requirement

In the event the data view has both mode: time_series and normal indexes then fall back onto field list as it is today.

Describe a specific use case for the feature:
When using a data view that has additional metadata about fields (what type of metrics are stored)
I need to find/sort my fields in Lens using this metadata
So I can discover what metrics are in my data
And distinguish metrics from numeric non-metrics

@ghudgins ghudgins added discuss enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Apr 20, 2022
@ghudgins ghudgins added this to Long-term goals in Lens via automation Apr 20, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@ghudgins
Copy link
Author

we need to discuss which design approach is better. here's a short pro / con list to begin the discussion @MichaelMarcialis @gvnmagni @flash1293

If we put metadata in the field list:

  • Pro: user can find metrics first (assumption: this is the first thing most people think about when visualizing metrics)
  • Pro: fewer fields to review then the large list

If we put metadata in the type selector

  • Pro: same method users have for non-TSDB metadata
  • Pro: easier to understand the order of the field list
  • Pro: easier to re-use field list

@flash1293
Copy link
Contributor

As in the presence of TSDB data most visualizations will be built with dimensions and metrics I think it makes sense to move them to the top by default.

@MichaelMarcialis
Copy link
Contributor

Note from dev: they can only afford 1 level of grouping in the field list. There is some weirdness with this one seeing that there would be no easy way to see fields in alphabetical order as they are today although maybe we could duplicate the info?

Perhaps we could offer a kind of view mode switcher that allows the user to switch between this new suggested view and the more traditional alphabetical view?

Filter by type idea
Add metric subclassifications to "Type" selector. Instead of number offer Gauge metrics Rate metrics etc...

Would this be in addition to the existing field type selections? Or in lieu of those for this mode? Asking because I think it would be odd to offer type filtering only on one subset of the field list.

Desired order:

  • Metrics
  • Dimensions
  • Other fields

Is the "Dimensions" name one that will resonate with our users? Would something like "Categories" be more common/understandable? Just curious.

@flash1293
Copy link
Contributor

Would this be in addition to the existing field type selections? Or in lieu of those for this mode? Asking because I think it would be odd to offer type filtering only on one subset of the field list.

All gauge and counter metrics are number fields, but not all number fields are gauges or metrics. I think we can add either another dimension to the filter (if number is picked, the user can also pick gauge/counter). Or flatten out the "number" type into "gauge metric", "counter metric", "other number field".

Is the "Dimensions" name one that will resonate with our users? Would something like "Categories" be more common/understandable? Just curious.

I think we should just follow whatever the Elasticsearch team will settle on, otherwise this becomes confusing. As an industry I think time series data bases do not use consistent terminology here (sometimes these fields are called labels or tags as well)

@ghudgins
Copy link
Author

Met this week and decided we'd start with the "Filter by type" changes first. This means we have two design needs CC @MichaelMarcialis - will add this to list

  • Add 2 new options in the type picker
  • need icons
  • Take a pass at the filter by type dropdown design

@stratoula
Copy link
Contributor

This is already possible
image

you can now filter by TSDB metrics in case they exist. I am closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
No open projects
Lens
  
Long-term goals
Development

No branches or pull requests

5 participants