Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metric Counter and Gauge Token Additions #6064

Merged
merged 3 commits into from
Jul 20, 2022
Merged

Metric Counter and Gauge Token Additions #6064

merged 3 commits into from
Jul 20, 2022

Conversation

MichaelMarcialis
Copy link
Contributor

@MichaelMarcialis MichaelMarcialis commented Jul 19, 2022 •
edited
Loading

Summary

Added new tokenMetricCounter and tokenMetricGauge tokens to EUI, in preparation to accommodate TSDB data in the Lens field list and accompanying filters (see elastic/kibana#130726).

image

Checklist

  • Checked in both light and dark modes
  • Checked in Chrome, Safari, Edge, and Firefox
  • Added documentation
  • Added or updated jest and cypress tests
  • Updated the Figma library counterpart
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6064/

@MichaelMarcialis MichaelMarcialis marked this pull request as ready for review July 19, 2022 20:49
@miukimiu miukimiu self-requested a review July 20, 2022 12:28
miukimiu
miukimiu approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@miukimiu miukimiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

And thanks for ordering the token types by name. 👍🏽

@MichaelMarcialis MichaelMarcialis merged commit 63ff92f into elastic:main Jul 20, 2022
@MichaelMarcialis MichaelMarcialis deleted the lens-tsdb-token-additions branch July 20, 2022 13:16
@cee-chen cee-chen mentioned this pull request Jul 27, 2022
Closed
@cee-chen cee-chen mentioned this pull request Aug 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miukimiu miukimiu miukimiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelMarcialis @kibanamachine @miukimiu