Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA][Code Coverage] Merging failing #132706

Closed
wayneseymour opened this issue May 23, 2022 · 1 comment · Fixed by #131734
Closed

[QA][Code Coverage] Merging failing #132706

wayneseymour opened this issue May 23, 2022 · 1 comment · Fixed by #131734
Assignees
@wayneseymour
Labels
code coverage Issues & PRs about code coverage Team:QA Team label for QA Team

Comments

@wayneseymour
Copy link
Member

wayneseymour commented May 23, 2022 •
edited

The code coverage ingestion system has been receiving "empty" coverage summary files for over a month.

Empty Example:

{
  "total": {
    "lines": {
      "total": 0,
      "covered": 0,
      "skipped": 0,
      "pct": "Unknown"
    },
    "statements": {
      "total": 0,
      "covered": 0,
      "skipped": 0,
      "pct": "Unknown"
    },
    "functions": {
      "total": 0,
      "covered": 0,
      "skipped": 0,
      "pct": "Unknown"
    },
    "branches": {
      "total": 0,
      "covered": 0,
      "skipped": 0,
      "pct": "Unknown"
    },
    "branchesTrue": {
      "total": 0,
      "covered": 0,
      "skipped": 0,
      "pct": "Unknown"
    }
  }
}
@wayneseymour wayneseymour added Team:QA Team label for QA Team code coverage Issues & PRs about code coverage labels May 23, 2022
@wayneseymour wayneseymour self-assigned this May 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@wayneseymour wayneseymour mentioned this issue May 23, 2022
Merged
wayneseymour added a commit that referenced this issue May 27, 2022
@wayneseymour @kibanamachine
[QA][Code Coverage] follow up pr for ftr auto config handling & fix m…
5f950e6 
…erge (#131734)

* [QA][Code Coverage] fixup for auto config handling pr

## Summary

Embed buildkite pipeline definition.

Follow up pr to change cc per auto config handling.
Also, resolves #132706

Increase worker count for `node scripts/build_kibana_platform_plugins` to 4 workers.

Normalize file names within coverage files such that nyc correctly builds the combined summaries.
  _Ci runs this on myriad servers, so the paths are different, which "breaks" nyc's output_

Split the final merge of functional coverage into 2 passes due to [nyc issue](istanbuljs/nyc#1263)

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wayneseymour wayneseymour

Labels
code coverage Issues & PRs about code coverage Team:QA Team label for QA Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[QA][Code Coverage] follow up pr for ftr auto config handling & fix merge elastic/kibana
2 participants
@wayneseymour @elasticmachine