Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Only show a warning when there's an older agent selected #132776

Closed
criamico opened this issue May 24, 2022 · 7 comments · Fixed by #136764
Closed

[Fleet] Only show a warning when there's an older agent selected #132776

criamico opened this issue May 24, 2022 · 7 comments · Fixed by #136764
Assignees
Labels
QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0

Comments

@criamico
Copy link
Contributor

Enhancement for #130259

The upgrade modal displays a static callout that warns the user that the rolling upgrade feature is only available for elastic agents having 8.3+ versions.

Let's make this warning dynamic and show it only when there is at least one agent older than 8.3 selected.

Screenshot 2022-05-24 at 09 48 41

@criamico criamico added Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0 labels May 24, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@jen-huang jen-huang added the QA:Needs Validation Issue needs to be validated by QA label Jun 29, 2022
@ghost
Copy link

ghost commented Jul 13, 2022

Hi @criamico

We have revalidated this feature on the latest 8.4.0-snapshot build and had below observations:

  • Static Warning callout is shown on the upgrade modal only when there is at least one agent older than 8.3.x.

image

  • Static Warning callout is not shown on the upgrade modal when agent version is >8.3.x.

image Build details:

Version: 8.4.0 SNAPSHOT
Build: 54427
Commit: 2de673f665783d7525f3cde8b6b266a471faef81

Hence, marking this as QA Validated.

Thanks!

@ghost ghost added the QA:Validated Issue has been validated by QA label Jul 13, 2022
@kpollich kpollich self-assigned this Jul 19, 2022
@ghost
Copy link

ghost commented Jul 20, 2022

Hi @criamico,

We have a query related to this ticket:

For which scenario/scenarios Upgrade warning callout Rolling upgrade only available for Elastic Agent versions 8.3+ should be available on the 'Schedule upgrade agent' flyout.

Kibana environment: 8.4.0 SNAPSHOT

  • Scenario 1: Selecting one/more than one agent < 8.3.x version
  • Scenario 2: Selecting one/more than one agent > or = 8.3.x version
  • Scenario 3: Selecting one agent on 8.2.0 version and second agent on 8.3.x versions

Please let us know if we are missing anything.

Thanks !

@criamico
Copy link
Contributor Author

Hi @prachigupta-qasource,
based on the changes introduced by @kpollich with #136764, the callout should be visible in case of Scenario 1 and 3, as both have at least one agent having version < 8.3.0.

Please check that the PR is already available on your test environment as it was merged 2 days ago.

@ghost
Copy link

ghost commented Jul 25, 2022

Hi @criamico,

Thank you for the confirmation. We have created below test cases for this feature under our Fleet Test Suite:

Note: We have created different test cases for upgrade modals:

  • Agent Upgrade modal
  • Schedule Upgrade modal

Please review the test cases and let us know if we are missing anything.

Thanks!

@ghost
Copy link

ghost commented Aug 2, 2022

Hi @criamico ,

We have re-validated this issue on the latest 8.4.0 BC1 build and observed that the issue is fixed.

Build details:

Version: 8.4.0 BC1
Build: 54999
Commit: 58f7eaf0f8dc3c43cbfcd393e587f155e97b3d0d

Below are the observations:

  • Scenario 1: Validate that the upgrade warning callout should be available on the Schedule upgrade agent flyout when the agent is older than the 8.3.x version

    • Selecting one agent < 8.3.x version. Available
    • Selecting more than one agent < 8.3.x version. Available
    • Selecting one agent > or equal 8.3.x version. Not Available
    • Selecting more than one agent > and = 8.3.x version. Not Available
Agents.-.Fleet.-.Elastic.-.Google.Chrome.2022-08-02.10-42-05.mp4
  • Scenario 2: Validate that the upgrade warning callout should be available on the Upgrade agent flyout when the agent is older than the 8.3.x version

    • Selecting one agent < 8.3.x version. Available
    • Selecting more than one agent < 8.3.x version. Available
    • Selecting one agent > or equal 8.3.x version. Not Available
    • Selecting more than one agent > and = 8.3.x version. Not Available
Agents.-.Fleet.-.Elastic.-.Google.Chrome.2022-08-02.10-44-00.mp4

Hence, marking this ticket as QA: Validated

Thanks!

@ghost ghost removed the QA:Needs Validation Issue needs to be validated by QA label Aug 2, 2022
@ghost
Copy link

ghost commented Aug 12, 2022

Hi Team,

We have executed 02 testcases for this feature under our Fleet Test run at Fleet 8.4.0-BC3 Feature test plan and found that it's working fine.

Build details:

Version: 8.4.0-BC3
Build: 55281
Commit: e42c547d7ab545472fd978383c2c43fa203a5b06

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants