Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Only show rolling upgrade warning if an outdated agent is selected #136764

Merged
merged 9 commits into from
Jul 21, 2022
Merged

[Fleet] Only show rolling upgrade warning if an outdated agent is selected #136764

merged 9 commits into from
Jul 21, 2022

Conversation

kpollich
Copy link
Member

Summary

Fixes #132776

  • Only show the "rolling upgrades" callout when an unsupported agent is included in the list of agents to upgrade

Screenshots

image

image

@kpollich kpollich added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0 labels Jul 20, 2022
@kpollich kpollich requested a review from a team as a code owner July 20, 2022 19:20
@kpollich kpollich self-assigned this Jul 20, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

kpollich
kpollich commented Jul 20, 2022
View reviewed changes
...ins/fleet/public/applications/fleet/sections/agents/components/agent_upgrade_modal/index.tsx
@@ -325,14 +330,21 @@ export const AgentUpgradeAgentModal: React.FunctionComponent<AgentUpgradeAgentMo
customOptionText="Input the desired version"
/>
</EuiFormRow>
{!isSingleAgent ? (
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this isSingleAgent distinction, but I'm not sure if that's necessary.

Copy link
Member

@nchaulet nchaulet Jul 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do not use the bulk upgrade and do not provide rolling upgrade option for single agent so it probably make no sense to show the warning for single agent.

@nchaulet
Copy link
Member

I think this will not work if you use a kuery (aka select all agents on all pages) it's similar to this #135337 I think it's an acceptable behavior as querying all agent in this case is not a scalable solution

nchaulet
nchaulet approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments but otherwise 🚀

@kpollich
Copy link
Member Author

I am unable to reproduce the Fleet cypress failures locally.

@kpollich
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@kpollich
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 865.8KB 866.1KB +311.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

@kpollich kpollich merged commit 48af0cc into elastic:main Jul 21, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 21, 2022
@criamico criamico mentioned this pull request Jul 22, 2022
Closed
@kpollich kpollich mentioned this pull request Jul 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

Assignees

@kpollich kpollich

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet] Only show a warning when there's an older agent selected
5 participants
@kpollich @elasticmachine @nchaulet @kibanamachine @kibana-ci