Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Analytics] Allow opt-in for random_sampler agg #132966

Open
Tracked by #166211
thomasneirynck opened this issue May 25, 2022 · 6 comments
Open
Tracked by #166211

[Analytics] Allow opt-in for random_sampler agg #132966

thomasneirynck opened this issue May 25, 2022 · 6 comments
Labels
enhancement New value added to drive a business result Feature:Maps impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Meta Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@thomasneirynck
Copy link
Contributor

thomasneirynck commented May 25, 2022

Describe the feature:

All apps in Analytics (Lens, Maps) should support the random_sample aggregation https://www.elastic.co/guide/en/elasticsearch/reference/master/search-aggregations-random-sampler-aggregation.html

Dashboards should surface a mechanism (a toggle, a slider) for users to trade speed vs accuray.

Describe a specific use case for the feature:

This is important for Dashboards to load fast, regardless of the size of the underlying data. Several apps already make tih trade-off of speed-vs-accuracy (e.g. ML, when doing log-rate analysis, or in the data-visualizer).

@thomasneirynck thomasneirynck added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure labels May 25, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@thomasneirynck thomasneirynck added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label May 25, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@thomasneirynck
Copy link
Contributor Author

Just put this in as placeholder for now. Details forthcoming.

@jb1b84 jb1b84 added Feature:Maps and removed [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Nov 3, 2022
@stratoula stratoula added the Meta label Jan 11, 2023
@drewdaemon drewdaemon added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Jan 19, 2023
@stratoula stratoula removed the Team:Visualizations Visualization editors, elastic-charts and infrastructure label May 31, 2023
@stratoula
Copy link
Contributor

I am removing the visualizations team assignment as random sampler has been added to Lens!

@thomasneirynck
Copy link
Contributor Author

thomasneirynck commented Sep 11, 2023

We probably should rewrite this a little. The issue with random sampler right now is that has not been designed as a Dashboard level setting. Rather, it is an advanced setting in Lens. This prevents users/authors to apply some global tradeoff of speed against precision.

This should behave more like a global setting. If an author discovers a Dashboard is slow, some kind of toggle/speed setting can be added to "enable sampling".

The main difference is here that random-sampling should not be a property of the chart, but rather a property of the reporting system (ie. the Dashboard).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Maps impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Meta Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

5 participants