Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases] Switch all custom API hooks to React Query #134663

Closed
cnasikas opened this issue Jun 17, 2022 · 2 comments · Fixed by #157254
Closed

[Cases] Switch all custom API hooks to React Query #134663

cnasikas opened this issue Jun 17, 2022 · 2 comments · Fixed by #157254
Assignees
@cnasikas
Labels
Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture

Comments

@cnasikas
Copy link
Member

PRs #133485, #133505, #133371, #133281, and #132784, introduced React Query in Cases. The following custom API hooks remain to be converted to React Query:

  • useUpdateCases
  • useCreateAttachments
  • useDeleteCases
  • useDeleteComment
  • useGetCasesMetrics
  • useGetCasesStatus
  • useGetFeatureIds
  • useGetReporters
  • usePostCase
  • usePostPushToService
  • useUpdateCase
  • useUpdateComment
@cnasikas cnasikas added technical debt Improvement of the software architecture and operational architecture Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature labels Jun 17, 2022
@cnasikas cnasikas self-assigned this Jun 17, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@cnasikas cnasikas mentioned this issue May 10, 2023
Merged
1 task
cnasikas added a commit that referenced this issue May 12, 2023
@cnasikas @kibanamachine
[Cases] Convert remaining hooks to React Query (#157254)
0bbef23 
## Summary

This PR converts the remaining cases' hooks to React Query. It also adds
the `QueryProvider` to the `CasesProvider` to be able to use the hooks
when attaching data to a case from outside cases like ML.

Fixes: #134663

## Testing

- Verify you can add a comment successfully and the new comment markdown
editor is empty after submission
- Verify you can add attachments to a new case and an existing case
- Add a file to a case. Verify that the entry in the user activity is
being shown
- Verify that you can push a case to an external service
- Verify that you can push a case to an external service when creating a
case
- Verify that the loading spinner is being shown when you edit a comment
in the actions of the comment
- Verify that the loading spinner is being shown when you edit a title
next to the title
- Verify that the loading spinner is being shown when you edit a tag
next to the tags section
- Verify that the loading spinner is being shown when you edit severity
next to the severity selectable
- Verify that the status and "Sync alerts" is disabled when changing the
status
- Verify that the status and "Sync alerts" is disabled when changing the
"Sync alerts"
- Verify that the "edit pencil" is changed to a loading spinner when
changing assignees
- Verify you can update a comment
- Verify you can update the fields of the case


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jasonrhodes pushed a commit that referenced this issue May 17, 2023
@cnasikas @kibanamachine @jasonrhodes
[Cases] Convert remaining hooks to React Query (#157254)
064684a 
## Summary

This PR converts the remaining cases' hooks to React Query. It also adds
the `QueryProvider` to the `CasesProvider` to be able to use the hooks
when attaching data to a case from outside cases like ML.

Fixes: #134663

## Testing

- Verify you can add a comment successfully and the new comment markdown
editor is empty after submission
- Verify you can add attachments to a new case and an existing case
- Add a file to a case. Verify that the entry in the user activity is
being shown
- Verify that you can push a case to an external service
- Verify that you can push a case to an external service when creating a
case
- Verify that the loading spinner is being shown when you edit a comment
in the actions of the comment
- Verify that the loading spinner is being shown when you edit a title
next to the title
- Verify that the loading spinner is being shown when you edit a tag
next to the tags section
- Verify that the loading spinner is being shown when you edit severity
next to the severity selectable
- Verify that the status and "Sync alerts" is disabled when changing the
status
- Verify that the status and "Sync alerts" is disabled when changing the
"Sync alerts"
- Verify that the "edit pencil" is changed to a loading spinner when
changing assignees
- Verify you can update a comment
- Verify you can update the fields of the case


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cnasikas cnasikas

Labels
Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Cases] Convert remaining hooks to React Query cnasikas/kibana
2 participants
@cnasikas @elasticmachine