Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Index Template] Preview strips dataStream prop making it impossible to preview a data stream #139925

Closed
Dosant opened this issue Sep 1, 2022 · 2 comments · Fixed by #140189
Closed
Labels
bug Fixes for quality problems that affect the customer experience Feature:Index Management Index and index templates UI impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@Dosant
Copy link
Contributor

Dosant commented Sep 1, 2022

Kibana version: main

Describe the bug:

When you create a template for data stream

Screenshot 2022-09-01 at 15 52 28

And then you click "Preview index template" in one of the steps, and the template is previewed as if the data stream option is off.

The dataStream prop on a template is removed here because it is an empty object, and it is striped:

const indexTemplate = serializeTemplate(stripEmptyFields(template) as TemplateDeserialized);

We don't hit this problem when we save the template because the strip function is used only to remove empty strings:

stripEmptyFields(template, {
types: ['string'],
}) as TemplateDeserialized

Any additional context:

This is important for #130715 because when we create a template for a time series data stream, we don't need to specify index routing, but it is required for index. This bug makes preview functionality not used when creating a template for time series data stream

@Dosant Dosant added bug Fixes for quality problems that affect the customer experience Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Team:AppServicesUx labels Sep 1, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@Dosant Dosant changed the title [Index Template] Preview strips data_steam prop making it impossible to preview a data stream [Index Template] Preview strips data_stream prop making it impossible to preview a data stream Sep 1, 2022
@Dosant Dosant changed the title [Index Template] Preview strips data_stream prop making it impossible to preview a data stream [Index Template] Preview strips dataStream prop making it impossible to preview a data stream Sep 1, 2022
@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Sep 1, 2022
@exalate-issue-sync exalate-issue-sync bot added the loe:small Small Level of Effort label Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Index Management Index and index templates UI impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants