Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] "Add Filter" treats field contents case insensitive, but does filter case sensitive #142064

Closed
rsdrakh opened this issue Sep 28, 2022 · 4 comments · Fixed by #149570
Closed
Labels
bug Fixes for quality problems that affect the customer experience :DataDiscovery/fix-it-week Feature:Filters Feature:Unified search Unified search related tasks impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects

Comments

@rsdrakh
Copy link

rsdrakh commented Sep 28, 2022

Kibana version: 8.4.1

Elasticsearch version: 8.4.1

Server OS version: Ubuntu 22.04 LTS

Browser version: Any

Browser OS version: Any

Original install method (e.g. download page, yum, from source, etc.): Any

Describe the bug:
When you have a field that contains the same information in different case notation (Example: host.name : Node01, node01, NODE01) between different indices (happens out of the box with different integrations), and you need to set a filter for that host.name, you need to add a filter like "field: host.name, operator: is one of" in Discovery. While picking the different case sensitive options, Kibana shows all 3 values in the list of host.name contents, but as soon as you add node01 as a value, Node01 and NODE01 disappears from the list and typing it says "node01 has already been added". The resulting filter, however, is case sensitive, so NODE01 and Node01 will not be shown in the results.
This is highly inconsistent.

Steps to reproduce:

  1. Have an index with 3 different documents, containing "host.name" with any of "node01", "Node01", "NODE01"
  2. Add Filter in Discovery picking "host.name" as field, "is one of" as operator, and try to pick all 3 variants as value from the list.
  3. save filter

Expected behavior:
If Filter UI value picker says "already picked" then the resulting filter should also be case insensitive
Screenshots (if relevant):
image

Errors in browser console (if relevant):
none

Provide logs and/or server output (if relevant):
not necessary

Any additional context:
This is an actual customer complaining.

@rsdrakh rsdrakh added the bug Fixes for quality problems that affect the customer experience label Sep 28, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 28, 2022
@dej611 dej611 added Feature:Discover Discover Application Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) labels Sep 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Sep 28, 2022
@kibanamachine kibanamachine added this to Inbox in Discover Sep 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@kertal kertal removed the Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) label Sep 28, 2022
@kibanamachine kibanamachine removed this from Inbox in Discover Sep 28, 2022
@Dosant
Copy link
Contributor

Dosant commented Sep 29, 2022

Thanks for reporting this!

this looks like a duplicate of #49450, but looks like that was closed by mistake, so keeping this one open.

The bug is coming from the UI library elastic/eui#1997. As soon as it is fixed, we can improve this in Kibana filters

@lukasolson lukasolson added Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) and removed Team:AppServicesUx labels Jan 23, 2023
@kibanamachine kibanamachine added this to Inbox in Discover Jan 23, 2023
@lukasolson lukasolson added blocked loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. :DataDiscovery/fix-it-week and removed blocked labels Jan 23, 2023
@jughosta jughosta added the Feature:Unified search Unified search related tasks label Jan 25, 2023
@jughosta
Copy link
Contributor

@stratoula @lukasolson
Eui now supports isCaseSensitive prop for EuiComboBox elastic/eui#6268 and we can fix it for Unified Search.

Discover automation moved this from Inbox to Done Jan 26, 2023
stratoula added a commit that referenced this issue Jan 26, 2023
…rs input (#149570)

## Summary

Closes #142064

Allows the selection/search of values that are same but have a different
case notation.
 

![uni](https://user-images.githubusercontent.com/17003240/214783777-3149430c-22fc-47d0-ae52-cc29a667134e.gif)
kqualters-elastic pushed a commit to kqualters-elastic/kibana that referenced this issue Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience :DataDiscovery/fix-it-week Feature:Filters Feature:Unified search Unified search related tasks impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

7 participants