Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Latency threshold rule type should differentiate buckets on multiple terms #143792

Closed
Tracked by #143881
ogupte opened this issue Oct 20, 2022 · 0 comments · Fixed by #143881
Closed
Tracked by #143881

[APM] Latency threshold rule type should differentiate buckets on multiple terms #143792

ogupte opened this issue Oct 20, 2022 · 0 comments · Fixed by #143881
Assignees
Labels
apm:alerting apm:release-feature APM UI - Release Feature Goal apm:test-plan-8.6.0 APM UI Test Plan for v8.6.0 apm:test-plan-done Pull request that was successfully tested during the test plan bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v8.6.0

Comments

@ogupte
Copy link
Contributor

ogupte commented Oct 20, 2022

A recent fix to the latency threshold rule type allows users who select "Environment: All" to differentiate between each environments for the selected aggregation type, instead of lumping them all into one bucket. This partially fixes the this rule type since the same should be done for the other dimensions where a user can select "All":

  • Service name
  • Transaction type

These fields, along with service environment, need to be included in a multiterms bucket aggregation since any combination among these dimensions each can trigger their own alert.

The query should also conditionally apply each of these params as terms filters if a specific param is selected on rule creation.

@dannycroft dannycroft added the apm:release-feature APM UI - Release Feature Goal label Oct 25, 2022
@dannycroft dannycroft added the apm:test-plan-8.6.0 APM UI Test Plan for v8.6.0 label Nov 2, 2022
@yngrdyn yngrdyn self-assigned this Nov 22, 2022
@yngrdyn yngrdyn added the apm:test-plan-done Pull request that was successfully tested during the test plan label Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:alerting apm:release-feature APM UI - Release Feature Goal apm:test-plan-8.6.0 APM UI Test Plan for v8.6.0 apm:test-plan-done Pull request that was successfully tested during the test plan bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v8.6.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants