[APM] Fix apm.transaction_duration alert to aggregrate over service environment #143238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/apm-ui (Team:APM) |
sorenlouv
approved these changes
Oct 12, 2022
sorenlouv
reviewed
Oct 12, 2022
x-pack/plugins/apm/server/routes/alerts/register_transaction_duration_alert_type.ts
Show resolved
Hide resolved
sorenlouv
reviewed
Oct 12, 2022
x-pack/plugins/apm/server/routes/alerts/register_transaction_duration_alert_type.ts
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
sorenlouv
reviewed
Oct 13, 2022
| value: 5500000, | ||
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| }, |
There was a problem hiding this comment.
I wish we had API test for our alerts:
- call an internal (apm) API to create a latency rule
- ingest synthtrace data that causes alerts to fire
- Retrieve alerts from alerts index and verify they have the expected dimensions associated.
There might be timing problems (I don't know how often the scheduler runs or how predictable it is). And currently we call the alerting API directly when creating alerts. In the ideal scenario we'd have our own api that would call the alerting api's underneath. This will also make it MUCH easier for end users to use the API to create specific apm rules.
sorenlouv
reviewed
Oct 14, 2022
x-pack/plugins/apm/server/routes/alerts/chart_preview/get_transaction_duration.ts
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
Oct 14, 2022
x-pack/plugins/apm/server/routes/alerts/register_transaction_duration_alert_type.ts
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
Oct 14, 2022
x-pack/plugins/apm/public/components/alerting/chart_preview/index.tsx
Outdated
Show resolved
Hide resolved
sorenlouv
approved these changes
Oct 14, 2022
💚 Build Succeeded
Metrics [docs]Async chunks
Public APIs missing exports
Page load bundle
History
To update your PR or re-run it, just comment with: |
This was referenced Oct 19, 2022
kc13greiner
pushed a commit
to kc13greiner/kibana
that referenced
this pull request
Oct 19, 2022
…nvironment (elastic#143238) * [APM] Fix apm.transaction_duration alert to aggregrate over service environment (elastic#143217) * PR feedback * updates the alert preview chart for Latency threshold to reflect the correct logic used in this fix * fixes linting errors * Adds shared helper function for avg or pct latencty aggregation * Renamed ChartPreview (multi)data props to `series` which is always an array * fixes test mock object * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * fixes status custom domain and type error * fixes type error * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * Default agg type fixes API test * fixes type error * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * fixes linting issue Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
guskovaue
pushed a commit
to guskovaue/kibana
that referenced
this pull request
Oct 22, 2022
…nvironment (elastic#143238) * [APM] Fix apm.transaction_duration alert to aggregrate over service environment (elastic#143217) * PR feedback * updates the alert preview chart for Latency threshold to reflect the correct logic used in this fix * fixes linting errors * Adds shared helper function for avg or pct latencty aggregation * Renamed ChartPreview (multi)data props to `series` which is always an array * fixes test mock object * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * fixes status custom domain and type error * fixes type error * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * Default agg type fixes API test * fixes type error * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * fixes linting issue Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
e40pud
pushed a commit
to e40pud/kibana
that referenced
this pull request
Oct 24, 2022
…nvironment (elastic#143238) * [APM] Fix apm.transaction_duration alert to aggregrate over service environment (elastic#143217) * PR feedback * updates the alert preview chart for Latency threshold to reflect the correct logic used in this fix * fixes linting errors * Adds shared helper function for avg or pct latencty aggregation * Renamed ChartPreview (multi)data props to `series` which is always an array * fixes test mock object * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * fixes status custom domain and type error * fixes type error * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * Default agg type fixes API test * fixes type error * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * fixes linting issue Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #143217
Fixes the Latency Threshold alert type in APM so that each environment is checked separately if the alert should be triggered. If an alert triggers for multiple environments in the same interval, an alert is triggered for each.