Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Upgrade Assistant] Doc links point to 7.17 #145092

Closed
afharo opened this issue Nov 14, 2022 · 3 comments · Fixed by #147585
Closed

[Upgrade Assistant] Doc links point to 7.17 #145092

afharo opened this issue Nov 14, 2022 · 3 comments · Fixed by #147585
Assignees
@TinaHeiligers
Labels
docs Feature:Upgrade Assistant Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@afharo
Copy link
Member

afharo commented Nov 14, 2022

Currently, whenever we refer the user to look at our Upgrade Assistant, we point them to the 7.17 version.

Even more, if we open the current version of the docs for Upgrade Assistant, it claims it's been moved to 7.17: https://www.elastic.co/guide/en/kibana/current/upgrade-assistant.html

In the scope of enabling it for minor upgrades, we should review the existing links to point to current? Or the previous minor?
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 14, 2022
@Bamieh
Copy link
Member

Bamieh commented Nov 14, 2022 •
edited
Loading

The idea, for now, is to point users to the current version of the stack, and then they'd be able to figure out if they need an upgrade or not.

For the future, we can grab this detail from an API but from what I understand there are no plans to put more effort into this until the feature owners (deployment management) pick it back again from the core team.

It seems this only needs a docs update:

This link seems to be correct but we need to update where it points to.

@afharo afharo added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Nov 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 14, 2022
@afharo
Copy link
Member Author

afharo commented Nov 14, 2022 •
edited
Loading

@Bamieh, I think the link you shared will be fixed if we remove these lines:

kibana/docs/redirects.asciidoc

Lines 399 to 402 in df1a662

[role="exclude",id="upgrade-assistant"]
== Upgrade Assistant
This content has moved. Refer to {kibana-ref-all}/7.17/upgrade-assistant.html[Upgrade Assistant].

I also found these other places linking to 7.17:

@TinaHeiligers TinaHeiligers self-assigned this Dec 13, 2022
@TinaHeiligers TinaHeiligers mentioned this issue Dec 15, 2022
Merged
1 task
TinaHeiligers added a commit that referenced this issue Dec 19, 2022
@TinaHeiligers
Updates upgrade assistant doclinks to point to current rather than ha…
049d802 
…rd-coded 7.17 (#147585)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Fix #145092
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 19, 2022
@TinaHeiligers
Updates upgrade assistant doclinks to point to current rather than ha…
f81a88a 
…rd-coded 7.17 (elastic#147585)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Fix elastic#145092

(cherry picked from commit 049d802)
kibanamachine added a commit that referenced this issue Dec 19, 2022
@kibanamachine @TinaHeiligers
[8.6] Updates upgrade assistant doclinks to point to current rather t…
cf147cb 
…han hard-coded 7.17 (#147585) (#147780)

# Backport

This will backport the following commits from `main` to `8.6`:
- [Updates upgrade assistant doclinks to point to current rather than
hard-coded 7.17
(#147585)](#147585)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Christiane (Tina)
Heiligers","email":"christiane.heiligers@elastic.co"},"sourceCommit":{"committedDate":"2022-12-19T16:19:26Z","message":"Updates
upgrade assistant doclinks to point to current rather than hard-coded
7.17 (#147585)\n\nCo-authored-by: Lisa Cawley
<lcawley@elastic.co>\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>\r\nFix
#145092
Assistant","docs","backport:prev-minor","v8.7.0"],"number":147585,"url":"#147585
upgrade assistant doclinks to point to current rather than hard-coded
7.17 (#147585)\n\nCo-authored-by: Lisa Cawley
<lcawley@elastic.co>\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>\r\nFix
#145092
upgrade assistant doclinks to point to current rather than hard-coded
7.17 (#147585)\n\nCo-authored-by: Lisa Cawley
<lcawley@elastic.co>\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>\r\nFix
#145092"}}]}]
BACKPORT-->

Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
crespocarlos pushed a commit to crespocarlos/kibana that referenced this issue Dec 23, 2022
@TinaHeiligers @crespocarlos
Updates upgrade assistant doclinks to point to current rather than ha…
e30c30d 
…rd-coded 7.17 (elastic#147585)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Fix elastic#145092
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TinaHeiligers TinaHeiligers

Labels
docs Feature:Upgrade Assistant Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
4 participants
@afharo @Bamieh @TinaHeiligers @elasticmachine