Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Settings page alerting defaults tab #145402

Closed
shahzad31 opened this issue Nov 16, 2022 · 3 comments · Fixed by #147339
Closed

[Synthetics] Settings page alerting defaults tab #145402

shahzad31 opened this issue Nov 16, 2022 · 3 comments · Fixed by #147339
Assignees
Labels
Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability

Comments

@shahzad31
Copy link
Contributor

image

The Alerting tab only has 1 setting - “Default Connector”. This information is necessary for Synthetics alerts to “work out of the box”. It uses a EuiPanel hasBorder paddingSize="l", EuiDescribedFromGroup , and an EuiComboBox which can be used to select one or connectors if they exist. Most of the code for this already exists for Uptime, but there are a few details to note:

  • For cloud deployments, the combobox should be pre-populated with the Elastic-cloud-SMTP connector. The “Email to” field should be pre-populated with the email address used to create the cloud account.
  • The “Email to” field only appears if an Email connector is selected. It appears directly below the combobox (the design is slightly different than Uptime).
    • When an empty “Email to” field appears, DO NOT immediately invalidate it like we currently do in Uptime.
  • If no connectors exist / none are selected
    • use placeholder text “Select one or more connectors”
    • show an empty message in the combobox dropdown that says “No connectors found. Try adding one.”
  • Clicking “Add connector” opens a flyout which is a shareable component. After configuring a connector in the flyout, it should be added to the combobox.
  • There is a disabled “Apply changes” button that toggles to a primary filled button when the form is “dirty”. When the form is dirty, another button “Discard changes” appears next to the “Apply changes button”.
    image
    • If users try and navigate away or close the page while the page has edits, show a browser dialogue window.
      • Title: “Discard changes?”
      • Message: “You changes will be lost if you leave this page”
      • Cancel button: “Cancel”
      • Confirm button: “Discard changes”
@shahzad31 shahzad31 added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Nov 16, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 self-assigned this Dec 12, 2022
shahzad31 added a commit that referenced this issue Dec 14, 2022
Co-authored-by: Alejandro Fernández Gómez <antarticonorte@gmail.com>
Fixes #145402
@shahzad31 shahzad31 removed their assignment Feb 9, 2023
@dominiqueclarke dominiqueclarke self-assigned this Feb 9, 2023
@dominiqueclarke
Copy link
Contributor

Post FF testing raised the following bugs

#151796
#151795
#151791

@dominiqueclarke
Copy link
Contributor

Post FF testing on 8.7.0-SNAPSHOT LGTM after bugs have been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants