Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] UI break for ML rule card under create a new rule for Basic License #145508

Closed
ghost opened this issue Nov 17, 2022 · 7 comments
Closed

[Security Solution] UI break for ML rule card under create a new rule for Basic License #145508

ghost opened this issue Nov 17, 2022 · 7 comments
Assignees
@vitaliidm
Labels
bug Fixes for quality problems that affect the customer experience Feature:Detection Alerts Security Solution Detection Alerts Feature fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Alerts Security Detection Alerts Area Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.0

Comments

@ghost
Copy link

ghost commented Nov 17, 2022

Describe the bug
UI break for ML rule card under create a new rule for Basic License

Build info

VERSION: 8.6.0 BC1
BUILD: 58392
COMMIT: 50a7feb0a5eb068d3acccc49c83b9ccb6db6734f

Preconditions

  1. Kibana should be running

Steps to Reproduce

  1. Login into Basic License
  2. Navigate to Security > rules Page
  3. Click on create a new Rule
  4. Observe that UI break for ML rule card under create a new rule for Basic License

Actual Result
UI break for ML rule card under create a new rule for Basic License

Expected Result
UI should not be break for ML rule card under create a new rule for Basic License

Screen-shot

image
@ghost ghost added bug Fixes for quality problems that affect the customer experience triage_needed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.0 labels Nov 17, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ghost
Copy link
Author

ghost commented Nov 17, 2022

@karanbirsingh-qasource Please review!!

@MadameSheema MadameSheema added Team:Detections and Resp Security Detection Response Team Team:Detection Alerts Security Detection Alerts Area Team labels Nov 17, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@vitaliidm vitaliidm assigned vitaliidm and unassigned marshallmain Nov 21, 2022
@vitaliidm vitaliidm added the Feature:Detection Alerts Security Solution Detection Alerts Feature label Nov 21, 2022
@vitaliidm
Copy link
Contributor

vitaliidm commented Nov 21, 2022 •
edited
Loading

Issue has been fixed in 8.7.0 by Upgrade EUI to v70.2.4.
Due to breaking changes, introduced there, this upgrade can't be applied to 8.6.0, past FF.
Eui team will look into it, whether possible fix can be applied to 8.6.0 only. Internal slack thread

@cee-chen cee-chen mentioned this issue Nov 21, 2022
Merged
3 tasks
vitaliidm pushed a commit that referenced this issue Nov 22, 2022
[EUI] Fix temporary selectable horizontal card workaround (#145932)
b52b34c 
## Summary

closes #145508

This workaround was added in 7832378. A non-temporary fix was pushed up in 8.7 (#144845), but rather than create a new EUI backport just for this issue, I'm opting to fix the 8.6-only workaround.

### Before

<img src="https://user-images.githubusercontent.com/61860752/202394082-c82006af-1492-4537-a354-8e2f60b4b45e.png" alt="">

### After

<img width="909" alt="" src="https://user-images.githubusercontent.com/549407/203149130-a5cc0a69-d736-4e89-9d26-6e5e870238b4.png">


### Checklist

- [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
@vitaliidm
Copy link
Contributor

Fixed in 8.6.0 in #145932

@vitaliidm vitaliidm added the QA:Ready for Testing Code is merged and ready for QA to validate label Nov 22, 2022
@MadameSheema
Copy link
Member

@deepikakeshav-qasource can you please validate the fix on next BC? Thanks :)

@ghost
Copy link
Author

ghost commented Nov 24, 2022

Hi Team,

We have validated this issue on 8.6.0 BC2 build and Observed that issue is Fixed. ✔️

Please find the below details:

Version: 8.6.0 BC2
BUILD: 58485
COMMIT: b52b34c2ff5216c395bd49c5fbc97744b646f34d

Screencast:

image

Hence, we closing this issue and marking as QA Validated!!

Thanks!!

@ghost ghost added the QA:Validated Issue has been validated by QA label Nov 24, 2022
@ghost ghost closed this as completed Nov 24, 2022
@ghost ghost removed the QA:Ready for Testing Code is merged and ready for QA to validate label Jan 23, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitaliidm vitaliidm

Labels
bug Fixes for quality problems that affect the customer experience Feature:Detection Alerts Security Solution Detection Alerts Feature fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Alerts Security Detection Alerts Area Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@elasticmachine @MadameSheema @marshallmain @vitaliidm