Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Style issue in Add Rule Flyout #146168

Closed
maryam-saeidi opened this issue Nov 23, 2022 · 4 comments
Closed

[BUG] Style issue in Add Rule Flyout #146168

maryam-saeidi opened this issue Nov 23, 2022 · 4 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.7.0

Comments

@maryam-saeidi
Copy link
Member

Copied from #145987

📝 Summary

Some pages under Observability App have a styling issue. Mostly margin and spacing issues.
The pages that are affected so far are:

  • Rule flyout

Screenshot 2022-11-22 at 14 18 17

Screenshot 2022-11-22 at 14 21 39

It could be related to #144845

Note: This upgrade contains breaking changes to `EuiFlexGroup` and
`EuiFlexGrid,` primarily around switching margins and negative margins
to `gap.` Please do a quick QA pass of your app to scan for any issues.
We're happy to help resolve minor fixes or potentially follow up after
PR merges. You can find us over in #eui!

✅ AC

  • Check the bug surface
  • It seems that the BCs are safe. 8.6. to be verified
  • Do the necessary fix
@maryam-saeidi maryam-saeidi added bug Fixes for quality problems that affect the customer experience Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.7.0 labels Nov 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@XavierM
Copy link
Contributor

XavierM commented Dec 8, 2022

@jcger Can you look at this one?

@jcger
Copy link
Contributor

jcger commented Dec 12, 2022

@maryam-saeidi could you please check again? I merged a fix for this here #147001 and now that I checked again just in case everything seems to be ok

@maryam-saeidi
Copy link
Member Author

@jcger Yes, in my recent branch, I saw the issue was fixed, thanks! 🙏🏻

Duplicate of #145999

@maryam-saeidi maryam-saeidi closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.7.0
Projects
No open projects
Development

No branches or pull requests

4 participants