Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] - Pages under Observability App have a styling issue. #145987

Closed
fkanout opened this issue Nov 22, 2022 · 1 comment · Fixed by #146144
Closed

[BUG] - Pages under Observability App have a styling issue. #145987

fkanout opened this issue Nov 22, 2022 · 1 comment · Fixed by #146144
Assignees
@CoenWarmer
Labels
bug Fixes for quality problems that affect the customer experience Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.7.0

Comments

@fkanout
Copy link
Contributor

fkanout commented Nov 22, 2022 •
edited by maryam-saeidi
Loading

📝 Summary

Some pages under Observability App have a styling issue. Mostly margin and spacing issues.
The pages that are affected so far are:

  • Alert Details pages - Actions button
  • Rule Details pages - Actions button

Screenshot 2022-11-22 at 13 49 00

Screenshot 2022-11-22 at 14 18 00

It could be related to #144845

Note: This upgrade contains breaking changes to `EuiFlexGroup` and
`EuiFlexGrid,` primarily around switching margins and negative margins
to `gap.` Please do a quick QA pass of your app to scan for any issues.
We're happy to help resolve minor fixes or potentially follow up after
PR merges. You can find us over in #eui!

✅ AC

  • Check the bug surface
  • It seems that the BCs are safe. 8.6. to be verified
  • Do the necessary fix
@fkanout fkanout added bug Fixes for quality problems that affect the customer experience Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.7.0 labels Nov 22, 2022
@CoenWarmer
Copy link
Contributor

CoenWarmer commented Nov 23, 2022 •
edited
Loading

The AddRuleFlyout component is owned by ResponseOps. Suggestion to break the big titles in that component part of this issue into its own issue and assign it to ResponseOps.

@CoenWarmer CoenWarmer self-assigned this Nov 23, 2022
@CoenWarmer CoenWarmer mentioned this issue Nov 23, 2022
Merged
@maryam-saeidi maryam-saeidi mentioned this issue Nov 23, 2022
Closed
CoenWarmer added a commit that referenced this issue Nov 24, 2022
@CoenWarmer
Fix spacing in popovers in Rule Detail and Alert Detail as a result o…
535d3f8 
…f Eui spacing updates (#146144)

Resolves #145987

## Summary

This fixes spacing in the popovers in Rule Detail and Alert Detail
header actions components.

<img width="219" alt="Screenshot 2022-11-23 at 13 09 07"
src="https://user-images.githubusercontent.com/535564/203557408-be09418e-0d6f-4416-bb0f-a301a14138c7.png">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CoenWarmer CoenWarmer

Labels
bug Fixes for quality problems that affect the customer experience Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.7.0
Projects
None yet
Milestone
No milestone
2 participants
@CoenWarmer @fkanout