Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Runtime fields returning array returns a Request error when using last_value operation #148613

Closed
dej611 opened this issue Jan 10, 2023 · 1 comment · Fixed by #149025
Closed

[Lens] Runtime fields returning array returns a Request error when using last_value operation #148613

dej611 opened this issue Jan 10, 2023 · 1 comment · Fixed by #149025
Assignees
@dej611
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
Lens

Comments

@dej611
Copy link
Contributor

dej611 commented Jan 10, 2023

Describe the bug:

When using a runtime field returning an array value (emitting multiple times) the last_value operation uses the top_metric operation rather than top_hits under the hood: this leads to an error on the workspace:

Screenshot 2023-01-10 at 10 12 06

Prior to 8.2 last_value was using top_hits who supported runtime fields array values, then #127151 changed the logic of it.
In 8.1 a table with a last_value metric of a runtime array field would produce this:
Screenshot 2023-01-10 at 10 15 17

Steps to reproduce:

  1. Create a runtime field runtime_array with the following content to the dataView:
emit('hello0');
emit('hello1');
  1. Create a table with a single last value metric for the runtime array field
  2. 💥

Expected behavior:
It should work as in 8.1 using top_hits.
@dej611 dej611 added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Jan 10, 2023
@kibanamachine kibanamachine added this to Long-term goals in Lens Jan 10, 2023
@dej611
Copy link
Contributor Author

dej611 commented Jan 10, 2023

The bug affects only non numeric field types:

Screenshot 2023-01-10 at 10 59 15

@dej611 dej611 self-assigned this Jan 17, 2023
This was referenced Jan 17, 2023
Closed
Merged
Lens automation moved this from Long-term goals to Done Jan 18, 2023
dej611 added a commit that referenced this issue Jan 18, 2023
@dej611
[Lens] Automatically enable show array values for non-numeric runtime…
aa66f9a 
… fields (#149025)

## Summary

Fixes #148613 

After investigating the issue via a different approach #149011 I've
decided to handle it in this minimal way.
This PR will automatically switch the `show_array` toggle for non
numeric fields avoiding as much as possible direct appearance of the
error to the user.
If the user decides to explicitly disable the toggle, then the runtime
error will be shown (the message there can still be improved).

### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces—unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes—Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dej611 dej611

Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
No open projects
Lens
  
Done
Milestone
No milestone
1 participant
@dej611