migrate all plugins to packages #149344
Assignees
Labels
Team:Operations
Team label for Operations Team
Comments
mistic
added
Team:Operations
spalger
pushed a commit
that referenced
this issue
Feb 9, 2023
Fixes #149344 This PR migrates all plugins to packages automatically. It does this using `node scripts/lint_packages` to automatically migrate `kibana.json` files to `kibana.jsonc` files. By doing this automatically we can simplify many build and testing procedures to only support packages, and not both "packages" and "synthetic packages" (basically pointers to plugins). The majority of changes are in operations related code, so we'll be having operations review this before marking it ready for review. The vast majority of the code owners are simply pinged because we deleted all `kibana.json` files and replaced them with `kibana.jsonc` files, so we plan on leaving the PR ready-for-review for about 24 hours before merging (after feature freeze), assuming we don't have any blockers (especially from @elastic/kibana-core since there are a few core specific changes, though the majority were handled in #149370). --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
spalger
pushed a commit
that referenced
this issue
Feb 9, 2023
With #149344 the codeowners has many more entries in it, and these entries are taking precedence because in codeowner files: https://help.github.com/articles/about-codeowners/ > Order is important; the last matching pattern takes the most precedence. This reverses the order of the codeowners file, placing all of the auto-generated codeowners at the top of the file, followed by the manually managed overrides, and finally followed by the "ultimate priority" rules which gives design codeowners over all .scss files in the repo.
mistic
pushed a commit
to mistic/kibana
that referenced
this issue
May 10, 2023
Fixes elastic#149344 This PR migrates all plugins to packages automatically. It does this using `node scripts/lint_packages` to automatically migrate `kibana.json` files to `kibana.jsonc` files. By doing this automatically we can simplify many build and testing procedures to only support packages, and not both "packages" and "synthetic packages" (basically pointers to plugins). The majority of changes are in operations related code, so we'll be having operations review this before marking it ready for review. The vast majority of the code owners are simply pinged because we deleted all `kibana.json` files and replaced them with `kibana.jsonc` files, so we plan on leaving the PR ready-for-review for about 24 hours before merging (after feature freeze), assuming we don't have any blockers (especially from @elastic/kibana-core since there are a few core specific changes, though the majority were handled in elastic#149370). --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 1b85815) # Conflicts: # .github/CODEOWNERS # src/dev/build/tasks/bundle_fleet_packages.ts # src/dev/tsconfig.json # yarn.lock
mistic
added a commit
that referenced
this issue
May 11, 2023
# Backport This will backport the following commits from `main` to `8.7`: - [[packages] migrate all plugins to packages (#148130)](#148130) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Spencer","email":"spencer@elastic.co"},"sourceCommit":{"committedDate":"2023-02-09T03:06:50Z","message":"[packages] migrate all plugins to packages (#148130)\n\nFixes #149344 PR migrates all plugins to packages automatically. It does this\r\nusing `node scripts/lint_packages` to automatically migrate\r\n`kibana.json` files to `kibana.jsonc` files. By doing this automatically\r\nwe can simplify many build and testing procedures to only support\r\npackages, and not both \"packages\" and \"synthetic packages\" (basically\r\npointers to plugins).\r\n\r\nThe majority of changes are in operations related code, so we'll be\r\nhaving operations review this before marking it ready for review. The\r\nvast majority of the code owners are simply pinged because we deleted\r\nall `kibana.json` files and replaced them with `kibana.jsonc` files, so\r\nwe plan on leaving the PR ready-for-review for about 24 hours before\r\nmerging (after feature freeze), assuming we don't have any blockers\r\n(especially from @elastic/kibana-core since there are a few core\r\nspecific changes, though the majority were handled in #149370).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"1b8581540295fde746dae6b4a09d74fb5821bfef","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:skip","v8.8.0"],"number":148130,"url":"#148130 migrate all plugins to packages (#148130)\n\nFixes #149344 PR migrates all plugins to packages automatically. It does this\r\nusing `node scripts/lint_packages` to automatically migrate\r\n`kibana.json` files to `kibana.jsonc` files. By doing this automatically\r\nwe can simplify many build and testing procedures to only support\r\npackages, and not both \"packages\" and \"synthetic packages\" (basically\r\npointers to plugins).\r\n\r\nThe majority of changes are in operations related code, so we'll be\r\nhaving operations review this before marking it ready for review. The\r\nvast majority of the code owners are simply pinged because we deleted\r\nall `kibana.json` files and replaced them with `kibana.jsonc` files, so\r\nwe plan on leaving the PR ready-for-review for about 24 hours before\r\nmerging (after feature freeze), assuming we don't have any blockers\r\n(especially from @elastic/kibana-core since there are a few core\r\nspecific changes, though the majority were handled in #149370).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"1b8581540295fde746dae6b4a09d74fb5821bfef"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"#148130 migrate all plugins to packages (#148130)\n\nFixes #149344 PR migrates all plugins to packages automatically. It does this\r\nusing `node scripts/lint_packages` to automatically migrate\r\n`kibana.json` files to `kibana.jsonc` files. By doing this automatically\r\nwe can simplify many build and testing procedures to only support\r\npackages, and not both \"packages\" and \"synthetic packages\" (basically\r\npointers to plugins).\r\n\r\nThe majority of changes are in operations related code, so we'll be\r\nhaving operations review this before marking it ready for review. The\r\nvast majority of the code owners are simply pinged because we deleted\r\nall `kibana.json` files and replaced them with `kibana.jsonc` files, so\r\nwe plan on leaving the PR ready-for-review for about 24 hours before\r\nmerging (after feature freeze), assuming we don't have any blockers\r\n(especially from @elastic/kibana-core since there are a few core\r\nspecific changes, though the majority were handled in #149370).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"1b8581540295fde746dae6b4a09d74fb5821bfef"}}]}] BACKPORT--> --------- Co-authored-by: Spencer <spencer@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: