Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Jest Tests.x-pack/plugins/triggers_actions_ui/public/application/sections/alerts_table - AlertsTable Alerts table UI actions column row loading state on action should show the row loader when callback triggered #151688

Closed
kibanamachine opened this issue Feb 21, 2023 · 7 comments · Fixed by #151761
Closed

Failing test: Jest Tests.x-pack/plugins/triggers_actions_ui/public/application/sections/alerts_table - AlertsTable Alerts table UI actions column row loading state on action should show the row loader when callback triggered #151688

kibanamachine opened this issue Feb 21, 2023 · 7 comments · Fixed by #151761
Assignees
@cnasikas
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 21, 2023 •
edited

A test failed on a tracked branch

Error: thrown: "Exceeded timeout of 5000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."
    at it (/var/lib/buildkite-agent/builds/kb-n2-4-spot-9fba0073391da591/elastic/kibana-on-merge/kibana/x-pack/plugins/triggers_actions_ui/public/application/sections/alerts_table/alerts_table.test.tsx:381:9)
    at _dispatchDescribe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-9fba0073391da591/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/index.js:91:26)
    at describe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-9fba0073391da591/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/index.js:55:5)
    at describe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-9fba0073391da591/elastic/kibana-on-merge/kibana/x-pack/plugins/triggers_actions_ui/public/application/sections/alerts_table/alerts_table.test.tsx:348:7)
    at _dispatchDescribe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-9fba0073391da591/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/index.js:91:26)
    at describe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-9fba0073391da591/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/index.js:55:5)
    at describe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-9fba0073391da591/elastic/kibana-on-merge/kibana/x-pack/plugins/triggers_actions_ui/public/application/sections/alerts_table/alerts_table.test.tsx:247:5)
    at _dispatchDescribe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-9fba0073391da591/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/index.js:91:26)
    at describe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-9fba0073391da591/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/index.js:55:5)
    at describe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-9fba0073391da591/elastic/kibana-on-merge/kibana/x-pack/plugins/triggers_actions_ui/public/application/sections/alerts_table/alerts_table.test.tsx:177:3)
    at _dispatchDescribe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-9fba0073391da591/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/index.js:91:26)
    at describe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-9fba0073391da591/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/index.js:55:5)
    at Object.describe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-9fba0073391da591/elastic/kibana-on-merge/kibana/x-pack/plugins/triggers_actions_ui/public/application/sections/alerts_table/alerts_table.test.tsx:80:1)
    at Runtime._execModule (/var/lib/buildkite-agent/builds/kb-n2-4-spot-9fba0073391da591/elastic/kibana-on-merge/kibana/node_modules/jest-runtime/build/index.js:1377:24)
    at Runtime._loadModule (/var/lib/buildkite-agent/builds/kb-n2-4-spot-9fba0073391da591/elastic/kibana-on-merge/kibana/node_modules/jest-runtime/build/index.js:989:12)
    at Runtime.requireModule (/var/lib/buildkite-agent/builds/kb-n2-4-spot-9fba0073391da591/elastic/kibana-on-merge/kibana/node_modules/jest-runtime/build/index.js:849:12)
    at jestAdapter (/var/lib/buildkite-agent/builds/kb-n2-4-spot-9fba0073391da591/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:77:13)
    at runTestInternal (/var/lib/buildkite-agent/builds/kb-n2-4-spot-9fba0073391da591/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/var/lib/buildkite-agent/builds/kb-n2-4-spot-9fba0073391da591/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:444:34)

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Feb 21, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Feb 21, 2023
@kibanamachine kibanamachine added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Feb 21, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Feb 21, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

jbudz added a commit that referenced this issue Feb 21, 2023
@jbudz
skip failing test suite (#151688)
144df81
@jbudz
Copy link
Member

jbudz commented Feb 21, 2023

Skipped

main: 144df81

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@cnasikas cnasikas self-assigned this Feb 21, 2023
@cnasikas cnasikas mentioned this issue Feb 21, 2023
Merged
@cnasikas cnasikas mentioned this issue Mar 1, 2023
Merged
3 tasks
@jcger jcger mentioned this issue Mar 6, 2023
Closed
@XavierM XavierM closed this as completed Mar 28, 2023
cnasikas added a commit that referenced this issue Mar 29, 2023
@cnasikas @kibanamachine
[RAM] Cases bulk actions & column improvements (#151761)
a47a3e1 
## Summary

This PR:
- Moves the case bulk actions from the solutions to the alert table
- Refetch when using the case row actions & the case bulk actions.
- Renames the `kibana.alert.case_ids` label to `Cases`
- Unskip the `alerts_table.test.tsx` test file and skip the individual
flaky tests. I run the test file 60 times in the CI without any issues
(9efed89)
- Renames the cases flyout and modal hook from `get*` to `use*`

Fixes: #151688

## Userflow

## Testing

### Alerts table

- The alerts table does not show the Cases column by default
- You can choose the case column from the fields modal. Type `Case` to
find the cases column
- The label of the column is `Cases`
- The label of the field in the fields modal is `Cases`
- You can bulk attach alerts to a new case
- You can bulk attach alerts to an existing case
- When bulk attaching alerts to a case the alerts table re-fetches the
data
- When attaching an alert to a case from the row actions the alerts
table re-fetches the data

### Case integrations outside the alerts table
- Ensure that you can attach your data to a case (existing and new)

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jgowdyelastic pushed a commit to jgowdyelastic/kibana that referenced this issue Mar 30, 2023
@cnasikas @kibanamachine @jgowdyelastic
[RAM] Cases bulk actions & column improvements (elastic#151761)
2102fa0 
## Summary

This PR:
- Moves the case bulk actions from the solutions to the alert table
- Refetch when using the case row actions & the case bulk actions.
- Renames the `kibana.alert.case_ids` label to `Cases`
- Unskip the `alerts_table.test.tsx` test file and skip the individual
flaky tests. I run the test file 60 times in the CI without any issues
(elastic@9efed89)
- Renames the cases flyout and modal hook from `get*` to `use*`

Fixes: elastic#151688

## Userflow

## Testing

### Alerts table

- The alerts table does not show the Cases column by default
- You can choose the case column from the fields modal. Type `Case` to
find the cases column
- The label of the column is `Cases`
- The label of the field in the fields modal is `Cases`
- You can bulk attach alerts to a new case
- You can bulk attach alerts to an existing case
- When bulk attaching alerts to a case the alerts table re-fetches the
data
- When attaching an alert to a case from the row actions the alerts
table re-fetches the data

### Case integrations outside the alerts table
- Ensure that you can attach your data to a case (existing and new)

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cnasikas cnasikas

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
5 participants
@XavierM @jbudz @cnasikas @elasticmachine @kibanamachine