Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Identify Rule Management Cypress tests ownership #153656

Closed
Tracked by #153633 ...
MadameSheema opened this issue Mar 24, 2023 · 3 comments · Fixed by #162373
Closed
Tracked by #153633 ...

[Security Solution] Identify Rule Management Cypress tests ownership #153656

MadameSheema opened this issue Mar 24, 2023 · 3 comments · Fixed by #162373
Assignees
Labels
8.10 candidate Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture test_ui_functional test

Comments

@MadameSheema
Copy link
Member

MadameSheema commented Mar 24, 2023

As part of the https://github.com/elastic/security-team/issues/6250 effort, we need to identify which test scenarios are owned by Detections and Response team.

In order to make this effort more granular and to have an up-to-date codeowners file, the task is going to be divided between the different area teams.

As an output, we are expecting to have the lists of Cypress tests owned by Rule Management team.

Please add a comment to this ticket with the tests your teams owns using the following formats:

If you own the whole file:

/x-pack/plugins/security_solution/cypress/e2e/detection_rules/bulk_edit_rules.cy.ts

If you own just some test(s) of the file:

/x-pack/plugins/security_solution/cypress/e2e/detection_rules/bulk_edit_rules.cy.ts
  Only prebuilt rules selected
  Prebuilt and custom rules selected: user proceeds with custom rules editing
@MadameSheema MadameSheema added the Team:Detection Rule Management Security Detection Rule Management Team label Mar 24, 2023
@banderror banderror added test test_ui_functional technical debt Improvement of the software architecture and operational architecture Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Mar 24, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@MadameSheema MadameSheema changed the title [Security Solution] Identify Detection Rules Cypress tests ownership [Security Solution] Identify Rule Management Cypress tests ownership May 10, 2023
@banderror
Copy link
Contributor

This ticket was addressed in #162373. According to the updated CODEOWNERS file, @elastic/security-detection-rule-management team owns the following folders with Cypress tests:

/x-pack/plugins/security_solution/cypress/e2e/detection_response/prebuilt_rules @elastic/security-detection-rule-management
/x-pack/plugins/security_solution/cypress/e2e/detection_response/rule_management @elastic/security-detection-rule-management

There's a x-pack/plugins/security_solution/cypress/e2e/detection_response/rule_actions folder that doesn't have a code owner yet, we'll discuss this with @yctercero and update the CODEOWNERS file as part of our further work on #153645.

@MadameSheema let me know if we need to do anything else as part of this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.10 candidate Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture test_ui_functional test
Projects
None yet
3 participants