[Security Solution] Restructure Cypress tests under security_solution/cypress/e2e/detection_rules folder
#162373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banderror
added
test
test_ui_functional
technical debt
banderror
force-pushed
the
security-cypress-restructure-e2e-folder
branch
from
a87ea18
to
95dbd3e
Compare
banderror
changed the title
security_solution/cypress/e2e/detection_rules folder
banderror
added
release_note:skip
banderror
force-pushed
the
security-cypress-restructure-e2e-folder
branch
from
95dbd3e
to
d0d1b46
Compare
yctercero
approved these changes
Jul 25, 2023
yctercero
reviewed
Jul 25, 2023
banderror
force-pushed
the
security-cypress-restructure-e2e-folder
branch
from
d0d1b46
to
6fd5f2a
Compare
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
yctercero
approved these changes
Jul 25, 2023
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @banderror |
rshen91
pushed a commit
to rshen91/kibana
that referenced
this pull request
Jul 26, 2023
…n/cypress/e2e/detection_rules` folder (elastic#162373) **Epic:** elastic#153633 **Partially addresses:** elastic#153645 ## Summary This PR builds upon elastic#161900 and moves tests located in the `e2e/detection_rules` folder into `e2e/detection_response` and splits them into multiple sub-folders according to the Detection Engine subdomains we have. It also updates the CODEOWNERS file accordingly. <img width="451" alt="Screenshot 2023-07-25 at 21 03 08" src="https://github.com/elastic/kibana/assets/7359339/fb6052c9-3c5d-4547-98f1-61f44b9f7187"> ## Details Specifically, changes in this PR include: - The `e2e/detections_response` folder was renamed to `e2e/detection_response`. - The `e2e/detections_response/bulk_actions` folder became `e2e/detection_response/rule_management/rule_actions/bulk_actions`. - Cypress tests for rule types (which actually test rule creation for different rule types) were moved to `e2e/detection_response/rule_creation`. - The CODEOWNERS file was updated. Things not addressed in this PR: - No ownership was assigned for `e2e/detection_response/rule_actions`. Will need to figure this out with @yctercero. - No restructuring was done for `security_solution/cypress/screens` and `security_solution/cypress/tasks`. Will be done in follow-up PRs. - No refactoring was done for the tests themselves. Some of this work is also upcoming. The full file structure of the `detection_response` tests looks like this: <img width="452" alt="Screenshot 2023-07-25 at 21 03 44" src="https://github.com/elastic/kibana/assets/7359339/2b89c6d2-9f2d-4cf6-914f-a71c3fa93595">
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
…n/cypress/e2e/detection_rules` folder (elastic#162373) **Epic:** elastic#153633 **Partially addresses:** elastic#153645 ## Summary This PR builds upon elastic#161900 and moves tests located in the `e2e/detection_rules` folder into `e2e/detection_response` and splits them into multiple sub-folders according to the Detection Engine subdomains we have. It also updates the CODEOWNERS file accordingly. <img width="451" alt="Screenshot 2023-07-25 at 21 03 08" src="https://github.com/elastic/kibana/assets/7359339/fb6052c9-3c5d-4547-98f1-61f44b9f7187"> ## Details Specifically, changes in this PR include: - The `e2e/detections_response` folder was renamed to `e2e/detection_response`. - The `e2e/detections_response/bulk_actions` folder became `e2e/detection_response/rule_management/rule_actions/bulk_actions`. - Cypress tests for rule types (which actually test rule creation for different rule types) were moved to `e2e/detection_response/rule_creation`. - The CODEOWNERS file was updated. Things not addressed in this PR: - No ownership was assigned for `e2e/detection_response/rule_actions`. Will need to figure this out with @yctercero. - No restructuring was done for `security_solution/cypress/screens` and `security_solution/cypress/tasks`. Will be done in follow-up PRs. - No refactoring was done for the tests themselves. Some of this work is also upcoming. The full file structure of the `detection_response` tests looks like this: <img width="452" alt="Screenshot 2023-07-25 at 21 03 44" src="https://github.com/elastic/kibana/assets/7359339/2b89c6d2-9f2d-4cf6-914f-a71c3fa93595">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic: #153633
Resolves: #153656
Partially addresses: #153645
Summary
This PR builds upon #161900 and moves tests located in the
e2e/detection_rulesfolder intoe2e/detection_responseand splits them into multiple sub-folders according to the Detection Engine subdomains we have. It also updates the CODEOWNERS file accordingly.Details
Specifically, changes in this PR include:
e2e/detections_responsefolder was renamed toe2e/detection_response.e2e/detections_response/bulk_actionsfolder becamee2e/detection_response/rule_management/rule_actions/bulk_actions.e2e/detection_response/rule_creation.Things not addressed in this PR:
e2e/detection_response/rule_actions. Will need to figure this out with @yctercero.security_solution/cypress/screensandsecurity_solution/cypress/tasks. Will be done in follow-up PRs.The full file structure of the
detection_responsetests looks like this: