Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AO] - use the annotations and the calculation of the time range from observability-alert-details #154845

Closed
Tracked by #150854
fkanout opened this issue Apr 12, 2023 · 2 comments · Fixed by #154569
Closed
Tracked by #150854

[AO] - use the annotations and the calculation of the time range from observability-alert-details #154845

fkanout opened this issue Apr 12, 2023 · 2 comments · Fixed by #154569
Assignees
@fkanout
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0

Comments

@fkanout
Copy link
Contributor

fkanout commented Apr 12, 2023 •
edited

📝 Summary

Part of #150854
Use the @kbn/observability-alert-details package components/functions for consistent user exp.

✅

  • Remove the redundant code
  • import the new components from the package
@fkanout fkanout added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0 labels Apr 12, 2023
@fkanout fkanout self-assigned this Apr 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@fkanout fkanout mentioned this issue Apr 12, 2023
Closed
22 tasks
@fkanout fkanout changed the title [AO] - use the annotations and the calculation of the time range from @kbn/observability-alert-details package [AO] - use the annotations and the calculation of the time range from observability-alert-details package Apr 12, 2023
@fkanout fkanout changed the title [AO] - use the annotations and the calculation of the time range from observability-alert-details package [AO] - use the annotations and the calculation of the time range from observability-alert-details Apr 12, 2023
@fkanout fkanout mentioned this issue Apr 12, 2023
Merged
fkanout added a commit that referenced this issue Apr 13, 2023
@fkanout
[AO] - Add rule-specific fields, threshold, and reuse alert details p…
89e8d03 
…ackage components (#154569)

## Summary
It fixes #153675, fixes #153567,
fixes #153946, fixes #154845

<img width="1603" alt="Screenshot 2023-04-11 at 17 40 38"
src="https://user-images.githubusercontent.com/6838659/231215968-63b9ab6d-3b82-47c6-ace9-347306283b2a.png">

---------
saarikabhasi pushed a commit to saarikabhasi/kibana that referenced this issue Apr 19, 2023
@fkanout @saarikabhasi
[AO] - Add rule-specific fields, threshold, and reuse alert details p…
59f9ff1 
…ackage components (elastic#154569)

## Summary
It fixes elastic#153675, fixes elastic#153567,
fixes elastic#153946, fixes elastic#154845

<img width="1603" alt="Screenshot 2023-04-11 at 17 40 38"
src="https://user-images.githubusercontent.com/6838659/231215968-63b9ab6d-3b82-47c6-ace9-347306283b2a.png">

---------
@maryam-saeidi
Copy link
Member

@fkanout Do we have a similar ticket for APM?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fkanout fkanout

Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0
Projects
None yet
Milestone
No milestone
3 participants
@fkanout @maryam-saeidi @elasticmachine