Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs Onboarding] System logs onboarding flow #154929

Closed
ogupte opened this issue Apr 13, 2023 · 2 comments · Fixed by #162600, #162706 or #162972
Closed

[Logs Onboarding] System logs onboarding flow #154929

ogupte opened this issue Apr 13, 2023 · 2 comments · Fixed by #162600, #162706 or #162972
Assignees
@yngrdyn @ogupte
Labels
8.10 candidate apm:test-plan-8.10.0 APM UI Test Plan for v8.10.0 apm:test-plan-done Pull request that was successfully tested during the test plan design Feature:Logs Onboarding Logs Onboarding feature Team:obs-ux-logs Observability Logs User Experience Team

Comments

@ogupte
Copy link
Contributor

ogupte commented Apr 13, 2023 •
edited by isaclfreire
Loading

The system logs flow for logs onboarding should be implemented based on the existing design. The user should be guided having no logs through the steps to configure streaming system logs via elastic agent. Then the user waits for the agent to be set up and logs to be ingested before directing them to logs exploration / Discover.

Step 1 - System logs as a card in the Observability landing page
Image

Step 2 - Install shipper
Image

Step 3 - Collect logs
Image
@ogupte ogupte added Team:APM All issues that need APM UI Team support 8.8 candidate apm:logs-onboarding labels Apr 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@gbamparop gbamparop changed the title [APM] System logs onboarding flow [Logs Onboarding] System logs onboarding flow Apr 17, 2023
@isaclfreire isaclfreire self-assigned this Apr 27, 2023
@isaclfreire isaclfreire changed the title [Logs Onboarding] System logs onboarding flow [Design] System logs onboarding flow Apr 27, 2023
@gbamparop gbamparop changed the title [Design] System logs onboarding flow [Logs Onboarding] System logs onboarding flow May 12, 2023
@ogupte ogupte self-assigned this Jul 11, 2023
This was referenced Jul 26, 2023
Closed
Merged
ogupte added a commit to ogupte/kibana that referenced this issue Jul 27, 2023
@ogupte
[Logs onboarding] Adds UI for System logs flow (elastic#154929)
2e0e55d
@ogupte ogupte mentioned this issue Jul 27, 2023
Merged
@yngrdyn yngrdyn mentioned this issue Jul 28, 2023
Merged
@yngrdyn yngrdyn self-assigned this Jul 31, 2023
yngrdyn added a commit that referenced this issue Aug 1, 2023
@yngrdyn
[Logs onboarding] Removing custom_logs from routes and making them mo…
378cd6f 
…re generic (#162706)

This PR is a preparation work for
#154929.

### Changes:
- Rearranged code to make routes more generic (Most of the changes).
- Added `type` to onboarding savedObject.
- Removed `status` route since it was not being used.
yngrdyn pushed a commit that referenced this issue Aug 1, 2023
@ogupte @kibanamachine
[Logs onboarding] Adds UI for System logs flow (#154929) (#162654)
a3281ad 
This addresses the UI code required for #154929. The API work can be
accomplished separately. The existing APIs (for custom logs) are used in
their place for this PR.

![Screenshot 2023-07-27 at 13 03
50](https://github.com/elastic/kibana/assets/1967266/f27a2063-822a-4169-bd98-f22985661349)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This was linked to pull requests Aug 1, 2023
[Logs onboarding] Refactors the install elastic agent steps to own component #162600
Merged
[Logs onboarding] Removing custom_logs from routes and making them more generic #162706
Merged
ThomThomson pushed a commit to ThomThomson/kibana that referenced this issue Aug 1, 2023
@yngrdyn
[Logs onboarding] Removing custom_logs from routes and making them mo…
69dd0cc 
…re generic (elastic#162706)

This PR is a preparation work for
elastic#154929.

### Changes:
- Rearranged code to make routes more generic (Most of the changes).
- Added `type` to onboarding savedObject.
- Removed `status` route since it was not being used.
ThomThomson pushed a commit to ThomThomson/kibana that referenced this issue Aug 1, 2023
@ogupte @kibanamachine
[Logs onboarding] Adds UI for System logs flow (elastic#154929) (elas…
3c72006 
…tic#162654)

This addresses the UI code required for elastic#154929. The API work can be
accomplished separately. The existing APIs (for custom logs) are used in
their place for this PR.

![Screenshot 2023-07-27 at 13 03
50](https://github.com/elastic/kibana/assets/1967266/f27a2063-822a-4169-bd98-f22985661349)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@yngrdyn yngrdyn mentioned this issue Aug 2, 2023
Merged
yngrdyn added a commit that referenced this issue Aug 4, 2023
@yngrdyn
[Logs onboarding] Generate elastic-agent.yml file for system logs (#1…
c54d297 
…62972)

Closes #154929.

This PR along with #162654,
#162706 and
#162600 completes the work
required for collect system logs.

### Changes
- `ObservabilityOnboardingType` now could be `logFiles | systemLogs`.
This help us to identify (without changing the script) whether we need
to retrieve the yaml configuration for customLogs or for systemLogs.
- Added `generateSystemLogsYml` which generates a specific configuration
for system logs.
- `get_has_logs.ts` was modified so we are querying the proper index
depending on the type of logs.

#### Demo


https://github.com/elastic/kibana/assets/1313018/47eca890-37b2-401e-9e41-67c978ab50ad
@yngrdyn yngrdyn added the apm:test-plan-8.10.0 APM UI Test Plan for v8.10.0 label Aug 16, 2023
@yngrdyn
Copy link
Contributor

yngrdyn commented Sep 12, 2023

This was tested in o11y-test qa serverless environmnet.

@yngrdyn yngrdyn added the apm:test-plan-done Pull request that was successfully tested during the test plan label Sep 12, 2023
@gbamparop gbamparop added Team:obs-ux-logs Observability Logs User Experience Team Feature:Logs Onboarding Logs Onboarding feature and removed Team:APM All issues that need APM UI Team support apm:logs-onboarding labels Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yngrdyn yngrdyn

@ogupte ogupte

Labels
8.10 candidate apm:test-plan-8.10.0 APM UI Test Plan for v8.10.0 apm:test-plan-done Pull request that was successfully tested during the test plan design Feature:Logs Onboarding Logs Onboarding feature Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Milestone
No milestone
5 participants
@yngrdyn @ogupte @gbamparop @elasticmachine @isaclfreire