Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Jest Tests.x-pack/plugins/cases/public/components/user_actions - UserActions pagination shows more button visible 21st user action added #156750

Closed
kibanamachine opened this issue May 4, 2023 · 6 comments · Fixed by #163474
Closed

Failing test: Jest Tests.x-pack/plugins/cases/public/components/user_actions - UserActions pagination shows more button visible 21st user action added #156750

kibanamachine opened this issue May 4, 2023 · 6 comments · Fixed by #163474
Assignees
@adcoelho
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented May 4, 2023 •
edited

A test failed on a tracked branch

TestingLibraryElementError: Unable to find an element by: [data-test-subj="user-actions-list"]

Ignored nodes: comments, script, style
<body>
  <div />
</body>
    at Object.getElementError (/var/lib/buildkite-agent/builds/kb-n2-4-spot-9b299a73ceda747f/elastic/kibana-on-merge/kibana/node_modules/@testing-library/dom/dist/config.js:40:19)
    at /var/lib/buildkite-agent/builds/kb-n2-4-spot-9b299a73ceda747f/elastic/kibana-on-merge/kibana/node_modules/@testing-library/dom/dist/query-helpers.js:90:38
    at /var/lib/buildkite-agent/builds/kb-n2-4-spot-9b299a73ceda747f/elastic/kibana-on-merge/kibana/node_modules/@testing-library/dom/dist/query-helpers.js:130:15
    at Object.getAllByTestId (/var/lib/buildkite-agent/builds/kb-n2-4-spot-9b299a73ceda747f/elastic/kibana-on-merge/kibana/x-pack/plugins/cases/public/components/user_actions/index.test.tsx:555:21)

First failure: CI Build - 8.8
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label May 4, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label May 4, 2023
@kibanamachine kibanamachine added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label May 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@botelastic botelastic bot removed the needs-team Issues missing a team label label May 4, 2023
@cnasikas cnasikas added the Feature:Cases Cases feature label May 5, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.9

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

mistic added a commit that referenced this issue Aug 1, 2023
@mistic
skip flaky suite (#156750)
3fe7ede
mistic added a commit that referenced this issue Aug 1, 2023
@mistic
skip flaky suite (#156750)
9cae08d
@mistic
Copy link
Member

mistic commented Aug 1, 2023

Skipped.

main: 3fe7ede
8.9: 9cae08d

ThomThomson pushed a commit to ThomThomson/kibana that referenced this issue Aug 1, 2023
@mistic
skip flaky suite (elastic#156750)
145db95
@adcoelho adcoelho mentioned this issue Aug 9, 2023
Merged
@adcoelho adcoelho self-assigned this Aug 9, 2023
adcoelho added a commit that referenced this issue Aug 9, 2023
@adcoelho
[Cases] Fix flaky test in user actions pagination (#163474)
49849cf 
Fixes #156750
Fixes #156747
Fixes #156744
Fixes #156743
Fixes #156748
Fixes #156746
Fixes #156745
Fixes #156749

## Summary

Basically what you suggested offline @js-jankisalvi.

| Scenario | Old Test | Functional test where it is covered |
| -------------   |  -------------   | ------------- |
| Only shows one list of user actions when `total_user_actions < 10` |
`'renders only one action list when user actions are less than or equal
to 10'` | `'initially renders user actions list correctly'`|
| `Show More` button does not show up when `total_user_actions <=
page_size` | `'shows more button visible 21st user action added'` |
`'initially renders user actions list correctly'` |
| Shows 2 user action lists when `total_user_actions > page_size` |
`'renders two user actions list when user actions are more than 10'` |
`'shows more actions on button click'` |
| loading spinner | `'Loading spinner when user actions loading'` |
`'shows more actions on button click'` |

## Flaky Test Runner

Let's make sure that the functional tests don't become flaky too.

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2826
bryce-b pushed a commit to bryce-b/kibana that referenced this issue Aug 9, 2023
@adcoelho @bryce-b
[Cases] Fix flaky test in user actions pagination (elastic#163474)
16dbe07 
Fixes elastic#156750
Fixes elastic#156747
Fixes elastic#156744
Fixes elastic#156743
Fixes elastic#156748
Fixes elastic#156746
Fixes elastic#156745
Fixes elastic#156749

## Summary

Basically what you suggested offline @js-jankisalvi.

| Scenario | Old Test | Functional test where it is covered |
| -------------   |  -------------   | ------------- |
| Only shows one list of user actions when `total_user_actions < 10` |
`'renders only one action list when user actions are less than or equal
to 10'` | `'initially renders user actions list correctly'`|
| `Show More` button does not show up when `total_user_actions <=
page_size` | `'shows more button visible 21st user action added'` |
`'initially renders user actions list correctly'` |
| Shows 2 user action lists when `total_user_actions > page_size` |
`'renders two user actions list when user actions are more than 10'` |
`'shows more actions on button click'` |
| loading spinner | `'Loading spinner when user actions loading'` |
`'shows more actions on button click'` |

## Flaky Test Runner

Let's make sure that the functional tests don't become flaky too.

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2826
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adcoelho adcoelho

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Cases] Fix flaky test in user actions pagination adcoelho/kibana
5 participants
@adcoelho @mistic @cnasikas @elasticmachine @kibanamachine